Skip to content

chore(_VisuallyHidden): Convert internal component _VisuallyHidden to CSS module styling #6083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 10, 2025
Merged

chore(_VisuallyHidden): Convert internal component _VisuallyHidden to CSS module styling #6083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3fc2f59
Convert to CSS modules
jonrohan May 20, 2025
e645c17
Add changeset
jonrohan May 20, 2025
764b996
Handle as prop
jonrohan May 20, 2025
670f040
Add sx prop
jonrohan May 20, 2025
815d3d5
Type fix
jonrohan May 20, 2025
41cd518
Pass along className in case needed
jonrohan May 20, 2025
8b3957e
Updating snapshots
jonrohan May 20, 2025
b5cf78a
Update packages/react/src/_VisuallyHidden.tsx
jonrohan May 21, 2025
9e02a81
Update packages/react/src/_VisuallyHidden.tsx
jonrohan May 21, 2025
5eff7b6
Merge branch 'main' into css_module_convert/_visuallyhidden
jonrohan Jul 7, 2025
24a9823
Generate new snapshot
jonrohan Jul 7, 2025
671f047
chore(VisuallyHidden): simplify Props interface and remove generic type
jonrohan Jul 7, 2025
d83f48e
Merge branch 'main' into css_module_convert/_visuallyhidden
primer[bot] Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smooth-steaks-hug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Convert `_VisuallyHidden` internal component to CSS modules
136 changes: 16 additions & 120 deletions packages/react/src/Autocomplete/__snapshots__/Autocomplete.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,8 @@ exports[`snapshots renders a custom empty state message 1`] = `
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<div
Expand Down Expand Up @@ -81,21 +68,8 @@ exports[`snapshots renders a loading state 1`] = `
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div
className="SpinnerWrapper"
Expand Down Expand Up @@ -168,21 +142,8 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<ul
Expand Down Expand Up @@ -668,21 +629,8 @@ exports[`snapshots renders a multiselect input 1`] = `
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<ul
Expand Down Expand Up @@ -1106,21 +1054,8 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = `
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<ul
Expand Down Expand Up @@ -1544,21 +1479,8 @@ exports[`snapshots renders a single select input 1`] = `
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<ul
Expand Down Expand Up @@ -2121,21 +2043,8 @@ exports[`snapshots renders with a custom text input component 1`] = `
id="customInput"
type="text"
/>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<ul
Expand Down Expand Up @@ -2719,21 +2628,8 @@ exports[`snapshots renders with an input value 1`] = `
type="text"
/>
</span>,
.c0 {
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
-webkit-clip: rect(0,0,0,0);
clip: rect(0,0,0,0);
white-space: nowrap;
border-width: 0;
}

<span
className="c0"
<span
className="InternalVisuallyHidden"
>
<div>
<div
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/CircleBadge/__snapshots__/CircleBadge.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

exports[`CircleBadge > respects the inline prop 1`] = `
<div
class="sc-ikkxIA jhJVVm"
class="sc-gFqAkR SqWoH"
/>
`;

exports[`CircleBadge > respects the variant prop 1`] = `
<div
class="sc-ikkxIA eMrppW"
class="sc-gFqAkR ebkeDz"
/>
`;

exports[`CircleBadge > uses the size prop to override the variant prop 1`] = `
<div
class="sc-ikkxIA dkwGym"
class="sc-gFqAkR kqQQpr"
size="20"
/>
`;
Loading
Loading