Skip to content

Dialog: move files, add a story #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2023
Merged

Dialog: move files, add a story #3019

merged 4 commits into from
Mar 13, 2023

Conversation

broccolinisoup
Copy link
Member

Tracking issue: https://github.com/github/primer/issues/1488

Add storybook stories for Dialog

Checklist

  • Ensure your chosen component has a component directory in the src directory
  • Ensure the component has a root story file in the component directory
  • Ensure that the root story file exports a Default story
  • Opt the component into storybook tests

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: f9cdfe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-3019 March 13, 2023 06:06 Inactive
@primer primer bot temporarily deployed to github-pages March 13, 2023 06:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3019 March 13, 2023 06:09 Inactive
@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Mar 13, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 94.67 KB (0%)
dist/browser.umd.js 95.24 KB (+0.01% 🔺)

@broccolinisoup broccolinisoup marked this pull request as ready for review March 13, 2023 11:21
@broccolinisoup broccolinisoup requested review from a team and JoshBowdenConcepts March 13, 2023 11:21
@broccolinisoup broccolinisoup added this pull request to the merge queue Mar 13, 2023
@broccolinisoup broccolinisoup mentioned this pull request Mar 13, 2023
Closed
Merged via the queue into main with commit 2d5ed00 Mar 13, 2023
@broccolinisoup broccolinisoup deleted the refactor-dialog branch March 13, 2023 22:38
broccolinisoup added a commit that referenced this pull request Mar 15, 2023
@broccolinisoup
Revert "Dialog: move files, add a story (#3019)"
f5a9f12 
This reverts commit 2d5ed00.
broccolinisoup added a commit that referenced this pull request Mar 15, 2023
@broccolinisoup
Revert Dialog and Dialog(draft) folder refactor that causes impor…
51cdbb0 
…t issues (#3040)

* Revert "Dialog: move files, add a story (#3019)"

This reverts commit 2d5ed00.

* Revert "Dialog v2: Move files, reformat stories and add e2e tests (#2984)"

This reverts commit 418f316.

* remove unused eslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@JoshBowdenConcepts JoshBowdenConcepts Awaiting requested review from JoshBowdenConcepts

Assignees
No one assigned
Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broccolinisoup @joshblack