Button style overrides for size medium break in 35.20

[mattcosta7]

Description

When applying size small or large, the sx overrides apply, howevever the color of the text loses its override when size=medium

Screen.Recording.2023-02-22.at.8.09.58.AM.mov

Steps to reproduce

Add a button with sx overrides, and apply size=small vs size=medium

Version

v35.20.0

Browser

No response

[langermank]

Thanks for filing this issue! I can reproduce this, however medium is the default size 🤔 so you don't ever really need to set size="medium". With that in mind, I'm not sure this is worth fixing (unless its an easy fix, which I suspect it might not be.) Tagging @broccolinisoup to see if she has any thoughts!

[mattcosta7]

With that in mind, I'm not sure this is worth fixing (unless its an easy fix, which I suspect it might not be.) Tagging @broccolinisoup to see if she has any thoughts!

I'd disagree that it's not worth fixing - unless we remove medium as a valid size prop? it seems like we shouldn't expose an API that breaks the styling of the feature?

[broccolinisoup]

Thanks @mattcosta7 for reporting the issue! I added a quick fix and seems to be working on the story #2929