This repository was archived by the owner on Jul 7, 2025. It is now read-only.
Updates a11y guidance for the RelativeTime component#795
Merged
Conversation
smockle
approved these changes
May 31, 2024
smockle
reviewed
May 31, 2024
|
|
||
| General recommended approaches are: | ||
|
|
||
| * For interactive elements (such as making the RelativeTime component a link), use the accessible [Primer Tooltip](https://primer.style/components/tooltip) to display the full date/time and hide the `title` attribute. There are examples on the React and Rails pages with this approach. |
Member
There was a problem hiding this comment.
Non-blocking: I’m a little worried that—because this paragraph links to the Tooltip docs—someone will search the React and Rails Tooltip pages for examples.
Could we link directly to the relevant RelativeTime stories, in Storybook/Lookbook (once they’re published)?
Contributor
Author
There was a problem hiding this comment.
Yes good call! Once those are merged I will update these links!
Contributor
Author
There was a problem hiding this comment.
Updated w/the Rails example, waiting until React's version has released and shipped in Storybook before updating the link to that one!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TylerJDev
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/github/accessibility/issues/6101.
Updates a11y guidance based on updates made to the RelativeTime components allowing them to be accessible.
Blocked by https://github.com/github/accessibility-audits/issues/5633 & https://github.com/github/accessibility-audits/issues/5524.