Skip to content

Conversation

vdepizzol
Copy link
Contributor

Instead of using single-value options in Storybook's viewport sizes, add support for minimum and maximum values for each of Primer's breakpoints, allowing for verifying exactly how the components and patterns behave in each breakpoint extreme (and whether it correctly adjusts as the breakpoint changes).

A few notes:

/cc @langermank

@vdepizzol vdepizzol requested a review from langermank November 2, 2021 20:37
@vdepizzol vdepizzol requested a review from a team as a code owner November 2, 2021 20:37
@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2021

⚠️ No Changeset found

Latest commit: ab02070

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 🚀

@vdepizzol vdepizzol merged commit 9fe621f into main Nov 2, 2021
@vdepizzol vdepizzol deleted the storybook-descriptive-breakpoints branch November 2, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants