Use min and max values in Storybook breakpoints #1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using single-value options in Storybook's viewport sizes, add support for minimum and maximum values for each of Primer's breakpoints, allowing for verifying exactly how the components and patterns behave in each breakpoint extreme (and whether it correctly adjusts as the breakpoint changes).
A few notes:
I'm using
xs
to define anything smaller than$width-sm
, as documented here:https://primer.style/css/support/breakpoints#breakpoint-variables
I'm using
375px
as the minimumxs
size as a reference to the minimum viewport size we should support./cc @langermank