fix(19443): TieredMenu items should not ignore MenuItem.tooltip if provided#19444
Merged
mehmetcetin01140 merged 1 commit intoprimefaces:masterfrom Mar 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19443
It seems that recent versions of
p-tieredmenuhave broken how the tooltip can be provided to be spawned (in this case, through splitbutton). WhiletooltipOptions.tooltipLabelworks, the previous format which is usingMenuItem.tooltipwill not lead to its content being rendered in ap-tooltip.If
tooltipOptions.tooltipLabelis the new format, maybe the document should be updated and the tooltip field marked as deprecated. Otherwise, this PR aims at re-enabling tooltip binding with theMenuItem.tooltipattribute.Tests added to make sure both formats enable tooltip to show up