Skip to content

fix: #19231 - v20 AutoComplete onAdd not triggering on Enter#19285

Merged
cetincakiroglu merged 1 commit intomasterfrom
issue-19232
Jan 19, 2026
Merged

fix: #19231 - v20 AutoComplete onAdd not triggering on Enter#19285
cetincakiroglu merged 1 commit intomasterfrom
issue-19232

Conversation

@mehmetcetin01140
Copy link
Copy Markdown
Contributor

@mehmetcetin01140 mehmetcetin01140 commented Jan 15, 2026

fixes #19231

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2026

Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2026

AI Code Review

Looks Good

Summary

Adds missing onAdd.emit() call when Enter key is pressed in multiple mode AutoComplete, ensuring consistent event emission behavior across different input methods (separator vs Enter key)

Issue Alignment

Excellent alignment. The PR directly addresses the reported issue where onAdd event was not firing when pressing Enter in multiple mode, while it was firing for separator characters. The fix is minimal and targeted.

This is an automated review. A maintainer will provide final approval.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 15, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
primeng Error Error Jan 15, 2026 11:57am
primeng-5lp7 Ready Ready Preview, Comment Jan 15, 2026 11:57am

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2026

Thanks a lot for your contribution! But, Unit tests failed. You can check the unit tests with the command 'pnpm run test:unit' and commit the changes.

@cetincakiroglu cetincakiroglu merged commit f78e9b0 into master Jan 19, 2026
4 of 6 checks passed
@cetincakiroglu cetincakiroglu deleted the issue-19232 branch January 19, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bot: looks-good

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v20 AutoComplete onAdd not triggering on Enter

2 participants

@mehmetcetin01140 @cetincakiroglu