Skip to content

fix: #19252 - Picklist showSourceFilter/showTargetFilter not working#19281

Merged
cetincakiroglu merged 1 commit intomasterfrom
issue-19252
Jan 19, 2026
Merged

fix: #19252 - Picklist showSourceFilter/showTargetFilter not working#19281
cetincakiroglu merged 1 commit intomasterfrom
issue-19252

Conversation

@mehmetcetin01140
Copy link
Copy Markdown
Contributor

fixes: #19252

@github-actions
Copy link
Copy Markdown

Thank you for your contribution! We will review your PR shortly. Please make sure to manually link it to an issue for proper tracking.

@github-actions
Copy link
Copy Markdown

AI Code Review

Looks Good

Summary

Fix for Picklist filter visibility: Changes the filter binding to respect showSourceFilter and showTargetFilter properties by combining them with filterBy using logical AND operators

Issue Alignment

Perfectly addresses the linked issue. The bug was that showSourceFilter/showTargetFilter properties were not working - filters were always shown when filterBy was set. The fix ensures filters are only shown when both filterBy is set AND the corresponding show*Filter property is true.


This is an automated review. A maintainer will provide final approval.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
primeng-5lp7 Ready Ready Preview, Comment Jan 15, 2026 9:40am

@cetincakiroglu cetincakiroglu merged commit 2c193ab into master Jan 19, 2026
5 of 6 checks passed
@cetincakiroglu cetincakiroglu deleted the issue-19252 branch January 19, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v20] Picklist showSourceFilter/showTargetFilter not working

2 participants