fix #19227, fixes Dynamic Dialog memory leak

packages/primeng/src/basecomponent/basecomponent.ts

@@ -42,6 +42,8 @@ export class BaseComponent<PT = any> implements Lifecycle {
 
     private _themeScopedListener: () => void;
 
+    private themeChangeListenerMap: Map<string, any> = new Map();
+
     /******************** Inputs ********************/
 
     /**
@@ -164,35 +166,31 @@ export class BaseComponent<PT = any> implements Lifecycle {
         // watch _dt_ changes
         effect((onCleanup) => {
             if (this.document && !isPlatformServer(this.platformId)) {
-                ThemeService.off('theme:change', this._themeScopedListener);
-
                 if (this.dt()) {
                     this._loadScopedThemeStyles(this.dt());
                     this._themeScopedListener = () => this._loadScopedThemeStyles(this.dt());
-                    this._themeChangeListener(this._themeScopedListener);
+                    this._themeChangeListener('_themeScopedListener', this._themeScopedListener);
                 } else {
                     this._unloadScopedThemeStyles();
                 }
             }
 
             onCleanup(() => {
-                ThemeService.off('theme:change', this._themeScopedListener);
+                this._offThemeChangeListener('_themeScopedListener');
             });
         });
 
         // watch _unstyled_ changes
         effect((onCleanup) => {
             if (this.document && !isPlatformServer(this.platformId)) {
-                ThemeService.off('theme:change', this._loadCoreStyles);
-
                 if (!this.$unstyled()) {
                     this._loadCoreStyles();
-                    this._themeChangeListener(this._loadCoreStyles); // Update styles with theme settings
+                    this._themeChangeListener('_loadCoreStyles', this._loadCoreStyles); // Update styles with theme settings
                 }
             }
 
             onCleanup(() => {
-                ThemeService.off('theme:change', this._loadCoreStyles);
+                this._offThemeChangeListener('_loadCoreStyles');
             });
         });
 
@@ -331,7 +329,7 @@ export class BaseComponent<PT = any> implements Lifecycle {
 
     private _loadStyles() {
         this._load();
-        this._themeChangeListener(() => this._load());
+        this._themeChangeListener('_load', () => this._load());
     }
 
     private _loadGlobalStyles() {
@@ -394,15 +392,25 @@ export class BaseComponent<PT = any> implements Lifecycle {
         this.scopedStyleEl?.remove();
     }
 
-    private _themeChangeListener(callback = () => {}) {
+    private _themeChangeListener(id: string, callback = () => {}) {
+        this._offThemeChangeListener(id);
         Base.clearLoadedStyleNames();
-        ThemeService.on('theme:change', callback.bind(this));
+        const hold = callback.bind(this);
+        this.themeChangeListenerMap.set(id, hold);
+        ThemeService.on('theme:change', hold);
     }
 
     private _removeThemeListeners() {
-        ThemeService.off('theme:change', this._loadCoreStyles);
-        ThemeService.off('theme:change', this._load);
-        ThemeService.off('theme:change', this._themeScopedListener);
+        this._offThemeChangeListener('_themeScopedListener');
+        this._offThemeChangeListener('_loadCoreStyles');
+        this._offThemeChangeListener('_load');
+    }
+
+    private _offThemeChangeListener(id: string) {
+        if (this.themeChangeListenerMap.has(id)) {
+            ThemeService.off('theme:change', this.themeChangeListenerMap.get(id));
+            this.themeChangeListenerMap.delete(id);
+        }
     }
 
     /********** Passthrough **********/

packages/primeng/src/dynamicdialog/dynamicdialog.ts

@@ -561,12 +561,6 @@ export class DynamicDialog extends BaseComponent<DialogPassThrough> {
     }
 
     onDestroy() {
-        if (this.componentRef && typeof this.componentRef.destroy === 'function') {
-            this.componentRef.destroy();
-        }
-    }
-
-    ngOnDestroy() {
         this.onContainerDestroy();
         if (this.componentRef && typeof this.componentRef.destroy === 'function') {
             this.componentRef.destroy();