feat!: bump default formatting version to composer version with fallaback to latest supported PHP

[czosel]

BREAKING CHANGE: If you didn't set the phpVersion option explicitly, the formatting will try and located the minimum supported version from your composer.json (require.php), else the latest supported PHP version (currently: 8.4) now (instead of 7.0).

As suggested in #2396 by @mreiden

[cseufert]

Just an idea, should we have a guess at this from the composer.json file at the project root? or is that too complicated? Look for

...
  "require": {
    "php": ">=8.2",
  }
...

[czosel]

@cseufert Sounds reasonable! I don't have much experience with composer - does one typically set the version constraint to be equal or above the PHP version that is actually in use? If yes, this would probably make sense. We could then implement a logic like this:

• Use phpVersion from prettier config
• If unset, use minimum PHP version from composer.json
• If unset, use default version

If this logic makes sense, we might still want to merge this PR (just to keep the fallback to a realistic value).

[hackel]

config.platform.php in composer.json is for the specific PHP version being used in production. You'll probably want to look at this value as well.

[cseufert]

I have added basic detection for min php version from composer.json package. Should work for most cases, falls back to 8.3 as default if composer.json not found, or invalid.

[czosel]

Just some minor things, nice work!!

[cseufert]

@czosel
I feel like this is ready to merge, however I did have to change the jest configuration, I think its for the best though.

[Copilot]

Pull Request Overview

This PR bumps the default PHP formatting target to 8.3, introduces automatic version detection via composer.json, and updates snapshots/tests to explicitly include version and trailing commas.

• Added getComposerPhpVer utility and set phpVersion default to getComposerPhpVer() ?? "8.3", plus added "8.4" to the choices.
• Updated run_spec invocations and Jest snapshots across many test suites to include explicit phpVersion: "7.0" and trailing commas.
• Expanded Jest’s testRegex to match all .spec.js/.spec.mjs files and added new tests for getComposerPhpVer.

Reviewed Changes

Copilot reviewed 46 out of 47 changed files in this pull request and generated 1 comment.

File	Description
src/options.mjs	Implements dynamic PHP version detection and bumps fallback to 8.3; adds 8.4 choice
jest.config.mjs	Broadens test matching pattern to .*\.spec\.m?js$
tests/composer-version/composer-version.spec.mjs	New tests covering getComposerPhpVer behavior
tests/trailing_commas/jsfmt.spec.mjs	Adds explicit phpVersion to formatting specs

Comments suppressed due to low confidence (2)

src/options.mjs:70

• Consider adding a unit test to verify that when no composer.json is found (or parsing fails), getComposerPhpVer() returns null and the default falls back to "8.3" as intended.

    default: getComposerPhpVer() ?? "8.3",

src/options.mjs:10

• [nitpick] The function name getComposerPhpVer could be expanded to getComposerPhpVersion for clarity and consistency with the phpVersion option name.

function getComposerPhpVer() {

[czosel]

Apart from the nitpick this looks good to me now 👍

[cseufert]

I have updated the docs, however thinking about it further, maybe auto should be the default, and prettier should return an error if the proejcts php version cannot be determined?

[czosel]

I have updated the docs, however thinking about it further, maybe auto should be the default, and prettier should return an error if the proejcts php version cannot be determined?

Interesting idea, that would make it easier to debug when the composer lookup is not working (instead of the silent fallback to 8.3). The downside is that for very simple setups without composer.json we would force users to set the version, where before we'd just assume a default.

Another idea would be to have two "special" settings:

• auto: composer.json or latest supported version (default, exactly as you currently implemented it)
• composer: Read from composer.json or return an error if version could not be determined
• (explicit version setting, same as now)

What do you think? Too much or just right? 🙃

[cseufert]

I have re-implemented the default version, check out the readme, but in essence auto is default, composer is commposer or fail, and existing versions still work. Fallback is now the latest version supported (8.4), I have re-based this on the main branch as well, and updated the test logic for some of the 8.4 tests.

Apologies, as this has turned into a rather large PR though now, as multiple things have changed at once.

plugin-php/README.md

Lines 191 to 205 in 1ea1177

	### \* `phpVersion` Configuration Notes :
	The default setting `auto`, attempts to auto-detect your supported php versions from a `composer.json` with in the
	current directory or any parent directory, the plugin will use a minimum supported php version from
	`{"require":{"php":"..."}}` to set the phpVersion. If not found or not able to be parsed, it will default to latest
	supported PHP version, which is currently `8.4`.
	You set the `phpVersion` to `composer` and this will only use the `composer.json` file to determine the php
	version, prettier will crash if the PHP cannot be determined.
	You can also set the `phpVersion` to a specific version, such as `7.4`, `8.0`, `8.1`, `8.2`, or `8.3`.
	**Please Note:** If the phpVersion is not set correctly for your environment, this plugin will product code that could
	be incompatible with your PHP runtime. For example, if you are using PHP 7.4, but the plugin is set to PHP 8.3, it will
	produce code that uses features not available in PHP 7.4.

[czosel]

@cseufert Looks great!! 💯 A few very small cleanups, then we're good to go 🚀

[czosel]

All good now! Thanks @cseufert 💯

[czosel]

Released in v0.24.0 🎉