Better descriptions for attack effect parameters in card data #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannye
approved these changes
Sep 14, 2025
| DEF FLAG_2_BIT_6_F EQU %110 | ||
| DEF IGNORE_THIS_ATTACK_F EQU %101 | ||
| DEF ENCOURAGE_THIS_ATTACK_F EQU %110 | ||
| DEF FLAG_2_BIT_7_F EQU %111 |
Member
There was a problem hiding this comment.
Wouldn't these constants be better as decimal instead of binary?
Contributor
Author
There was a problem hiding this comment.
Most likely. I never understood why they were originally written like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a suggestion from ElectroDeoxys, I copied some card data comments from my poketcg_v2 repository.