Auto update sphinx theme css files#291
Merged
Merged
Conversation
Contributor
Author
|
@ZacBlanco @wanglinsong can you help to review this PR, thanks. |
ZacBlanco
reviewed
Feb 17, 2025
ZacBlanco
approved these changes
Mar 11, 2025
Contributor
Author
|
@ZacBlanco @wanglinsong seems I don't have access to merge PR, can you help to merge this PR, thanks. |
6 tasks
Contributor
Author
|
Validated by the new release action =>https://github.com/unix280/presto/actions/runs/13844025717/job/38739241705#step:8:21 Auto added the css files and updated with the script in @tdcmeehan 's release doc |
6 tasks
wanglinsong
requested changes
Apr 1, 2025
wanglinsong
left a comment
wanglinsong
left a comment
Member
There was a problem hiding this comment.
Please also generate package-lock.json file and check it in.
| process.exit(0); | ||
| } | ||
|
|
||
| updateSphinxThemeFiles().catch(console.error); No newline at end of file |
unidevel
force-pushed
the
auto_update_theme_files
branch
from
4379a97 to
f0beb13
Compare
Contributor
Author
Since we are using yarn in the github action, I generated |
unidevel
added a commit
to prestodb/presto
that referenced
this pull request
Apr 9, 2025
) ## Description This is a follow up of PR #24697, seperate the github release actions into 2 PRs. This is the second one - publish release artifacts like jars, docker images, websites, etc. The document of stable release process can be found in https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months) <!---Describe your changes in detail--> Prior to the coming release, there were 5 steps: - [Step 1 - Create a release branch and increment the version in the master branch](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-1-create-a-release-branch-and-increment-the-version-in-the-master-branch) - [Step 2 - Create release notes PR](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)) - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) ### Action "Presto Stable Release -Publish" <img width="969" alt="presto_release_publish_workflow" src="https://github.com/user-attachments/assets/31e941ac-c3b9-4a2d-9660-1e9bfaaf2e26" /> - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) #### Parameters <img width="309" alt="presto_release_publish_inputs" src="https://github.com/user-attachments/assets/54e18451-e99c-43b0-9921-a90983edd592" /> #### Jobs  This PR required prestodb/presto-release-tools#47, prestodb/prestodb.github.io#291 to be merged and released a new version`presto-release-tools` of before using these 2 actions ## Motivation and Context ## Impact Presto stable release ## Test Plan - Tested with my env - Publish => https://github.com/unix280/presto/actions/runs/13844025717 - Test with new release 0.292 after merged ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
j-sund
pushed a commit
to j-sund/presto-rcos
that referenced
this pull request
Apr 10, 2025
…stodb#24821) ## Description This is a follow up of PR prestodb#24697, seperate the github release actions into 2 PRs. This is the second one - publish release artifacts like jars, docker images, websites, etc. The document of stable release process can be found in https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months) <!---Describe your changes in detail--> Prior to the coming release, there were 5 steps: - [Step 1 - Create a release branch and increment the version in the master branch](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-1-create-a-release-branch-and-increment-the-version-in-the-master-branch) - [Step 2 - Create release notes PR](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)) - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) ### Action "Presto Stable Release -Publish" <img width="969" alt="presto_release_publish_workflow" src="https://github.com/user-attachments/assets/31e941ac-c3b9-4a2d-9660-1e9bfaaf2e26" /> - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) #### Parameters <img width="309" alt="presto_release_publish_inputs" src="https://github.com/user-attachments/assets/54e18451-e99c-43b0-9921-a90983edd592" /> #### Jobs  This PR required prestodb/presto-release-tools#47, prestodb/prestodb.github.io#291 to be merged and released a new version`presto-release-tools` of before using these 2 actions ## Motivation and Context ## Impact Presto stable release ## Test Plan - Tested with my env - Publish => https://github.com/unix280/presto/actions/runs/13844025717 - Test with new release 0.292 after merged ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
pradeepvaka
pushed a commit
to pradeepvaka/presto
that referenced
this pull request
Apr 11, 2025
…stodb#24821) ## Description This is a follow up of PR prestodb#24697, seperate the github release actions into 2 PRs. This is the second one - publish release artifacts like jars, docker images, websites, etc. The document of stable release process can be found in https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months) <!---Describe your changes in detail--> Prior to the coming release, there were 5 steps: - [Step 1 - Create a release branch and increment the version in the master branch](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-1-create-a-release-branch-and-increment-the-version-in-the-master-branch) - [Step 2 - Create release notes PR](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)) - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) ### Action "Presto Stable Release -Publish" <img width="969" alt="presto_release_publish_workflow" src="https://github.com/user-attachments/assets/31e941ac-c3b9-4a2d-9660-1e9bfaaf2e26" /> - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) #### Parameters <img width="309" alt="presto_release_publish_inputs" src="https://github.com/user-attachments/assets/54e18451-e99c-43b0-9921-a90983edd592" /> #### Jobs  This PR required prestodb/presto-release-tools#47, prestodb/prestodb.github.io#291 to be merged and released a new version`presto-release-tools` of before using these 2 actions ## Motivation and Context ## Impact Presto stable release ## Test Plan - Tested with my env - Publish => https://github.com/unix280/presto/actions/runs/13844025717 - Test with new release 0.292 after merged ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
AnuragKDwivedi
pushed a commit
to AnuragKDwivedi/presto-1
that referenced
this pull request
Apr 21, 2025
…stodb#24821) ## Description This is a follow up of PR prestodb#24697, seperate the github release actions into 2 PRs. This is the second one - publish release artifacts like jars, docker images, websites, etc. The document of stable release process can be found in https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months) <!---Describe your changes in detail--> Prior to the coming release, there were 5 steps: - [Step 1 - Create a release branch and increment the version in the master branch](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-1-create-a-release-branch-and-increment-the-version-in-the-master-branch) - [Step 2 - Create release notes PR](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)) - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) ### Action "Presto Stable Release -Publish" <img width="969" alt="presto_release_publish_workflow" src="https://github.com/user-attachments/assets/31e941ac-c3b9-4a2d-9660-1e9bfaaf2e26" /> - [Step 3: clean up the tag](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-3-clean-up-the-tag) - [Step 4: Publish Maven and Docker artifacts](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-4-publish-maven-and-docker-artifacts) - [Step 5: Publish docs website](https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website) #### Parameters <img width="309" alt="presto_release_publish_inputs" src="https://github.com/user-attachments/assets/54e18451-e99c-43b0-9921-a90983edd592" /> #### Jobs  This PR required prestodb/presto-release-tools#47, prestodb/prestodb.github.io#291 to be merged and released a new version`presto-release-tools` of before using these 2 actions ## Motivation and Context ## Impact Presto stable release ## Test Plan - Tested with my env - Publish => https://github.com/unix280/presto/actions/runs/13844025717 - Test with new release 0.292 after merged ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. ## Release Notes ``` == NO RELEASE NOTE == ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will update the siteConfig.js automatically.
Also no need to replace
@supportin the css file manually.Address the issue in step 5 => https://github.com/prestodb/presto/wiki/Stable-release-process-(every-2-months)#step-5-publish-docs-website
To make auto fix when commit working, please run
Then commit the newly added css files.
Usually when developer test the doc generation locally before commit, the siteConfig.js will be auto fixed.
Also provide the manual comamnd update siteConfig.js