Skip to content

test: (doNotReview) Bump Velox submodule to include array_top_n transform PR#27705

Draft
allenshen13 wants to merge 1 commit intoprestodb:masterfrom
allenshen13:velox-bump-array-top-n-16048
Draft

test: (doNotReview) Bump Velox submodule to include array_top_n transform PR#27705
allenshen13 wants to merge 1 commit intoprestodb:masterfrom
allenshen13:velox-bump-array-top-n-16048

Conversation

@allenshen13
Copy link
Copy Markdown
Member

@allenshen13 allenshen13 commented May 1, 2026

Bumps presto-native-execution/velox by exactly one commit (a05c16b4b) implementing array_top_n with a lambda transform argument.
Companion: facebookincubator/velox#16048

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

Summary by Sourcery

New Features:

  • Expose upstream Velox support for array_top_n with a lambda transform argument via the updated submodule reference.

@allenshen13 allenshen13 requested review from a team as code owners May 1, 2026 22:34
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label May 1, 2026
@prestodb-ci prestodb-ci requested review from a team, shuangli999 and sumi-mathew and removed request for a team May 1, 2026 22:34
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented May 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the presto-native-execution/velox submodule to point to a newer Velox commit (a05c16b4b) that introduces array_top_n with a lambda transform argument, without any other in-repo code changes.

File-Level Changes

Change Details Files
Advance the Velox git submodule to a specific newer commit that includes array_top_n with a lambda transform transform argument.
  • Update the Velox submodule reference to commit a05c16b4b.
  • Pull in upstream Velox changes associated with implementing array_top_n supporting a lambda transform argument.
  • Do not modify any Presto-native code or configuration beyond the submodule pointer.
presto-native-execution/velox

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@allenshen13 allenshen13 marked this pull request as draft May 1, 2026 22:34
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Bumps presto-native-execution/velox by exactly one commit
(32dba39d0) implementing array_top_n with a lambda transform
argument. The new pin is master's current velox pin (7dcf49cee)
with just that commit cherry-picked on top, so this PR isolates
the CI signal from unrelated upstream Velox churn.

This is a draft branch to exercise CI against the upcoming Velox
change so the Presto Java / native signature divergence for
array_top_n (Java comparator form vs. Velox transform form) can
be validated before the Velox PR is merged and the submodule is
bumped on master.

Companion: facebookincubator/velox#16048
@allenshen13 allenshen13 force-pushed the velox-bump-array-top-n-16048 branch from 6ed9a36 to 9aa9878 Compare May 4, 2026 14:42
@allenshen13 allenshen13 changed the title test (doNotReview): Bump Velox submodule to include array_top_n transform PR test: (doNotReview) Bump Velox submodule to include array_top_n transform PR May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants