Skip to content

Conversation

pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Aug 18, 2025

Description

This change updates the Jackson @JsonCreator constructor in BuiltInFunctionHandle to support an additional BuiltInFunctionKind enum parameter. The goal is to extend functionality while keeping backward compatibility with existing JSON payloads.

Motivation and Context

#25597 added an additional BuiltInFunctionKind enum parameter in BuiltInFunctionHandle's constructor. We need to add serialization / deserialization support for the newly added constructor argument.

Impact

No impact

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add support for BuiltInFunctionKind enum parameter in BuiltInFunctionHandle's JSON constructor creator

@pdabre12 pdabre12 requested review from a team as code owners August 18, 2025 21:43
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Aug 18, 2025
@prestodb-ci prestodb-ci requested review from a team, jkhaliqi and libianoss and removed request for a team August 18, 2025 21:43
@pdabre12 pdabre12 changed the title Support BuiltInFunctionKind enum parameter in BuiltInFunctionHandle JSON creator Support BuiltInFunctionKind enum parameter in BuiltInFunctionHandle JSON constructor creator Aug 18, 2025
@pdabre12 pdabre12 changed the title Support BuiltInFunctionKind enum parameter in BuiltInFunctionHandle JSON constructor creator Support BuiltInFunctionKind enum parameter in BuiltInFunctionHandle's JSON constructor creator Aug 18, 2025
@pdabre12 pdabre12 requested a review from kevintang2022 August 20, 2025 16:49
@pdabre12 pdabre12 merged commit 62226d5 into prestodb:master Aug 20, 2025
73 of 74 checks passed
@pdabre12 pdabre12 deleted the enum-parameter branch August 20, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants