Add output size calculation to BinarySortableSerializer#25359
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76008301 |
Contributor
|
Saved that user @emilysun201309 is from Meta |
Contributor
|
Thanks for the release note! Consider if you can add in the release note entry, describing what this means for a Presto user. |
xiaoxmeng
previously approved these changes
Jun 18, 2025
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76008301 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: prestodb#25359 `BinarySortableSerializer::serializedSizeInBytes` does a pass over the input data to calculate the output size in bytes. This is used to pre-determine the output buffer size to allocate. Reviewed By: xiaoxmeng Differential Revision: D76008301
emilysun201309
force-pushed
the
export-D76008301
branch
from
f7ebaac to
602af26
Compare
Summary: Pull Request resolved: prestodb#25359 `BinarySortableSerializer::serializedSizeInBytes` does a pass over the input data to calculate the output size in bytes. This is used to pre-determine the output buffer size to allocate. Reviewed By: xiaoxmeng Differential Revision: D76008301
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D76008301 |
xiaoxmeng
approved these changes
Jun 18, 2025
emilysun201309
force-pushed
the
export-D76008301
branch
from
602af26 to
a025765
Compare
6 tasks
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
BinarySortableSerializer::serializedSizeInBytesdoes a pass over the input data to calculate the output size in bytes. This is used to pre-determine the output buffer size to allocate.Differential Revision: D76008301