Add session property for passing query client timeout value#25210
Merged
Conversation
pgupta2
requested review from
a team,
elharo,
feilong-liu,
jaystarshot and
vivek-bharathan
as code owners
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D75480566 |
pgupta2
added a commit
to pgupta2/presto
that referenced
this pull request
May 27, 2025
…#25210) Summary: Currently, client timeout value is passed via query.client.timeout config property which applies to all queries. Adding corresponding session property which can be used to specify timeout values at query level, if needed. Differential Revision: D75480566
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D75480566 |
Contributor
|
Please document the new session property at https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/admin/properties-session.rst. |
pgupta2
added a commit
to pgupta2/presto
that referenced
this pull request
May 28, 2025
…#25210) Summary: Currently, client timeout value is passed via query.client.timeout config property which applies to all queries. Adding corresponding session property which can be used to specify timeout values at query level, if needed. Differential Revision: D75480566
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D75480566 |
feilong-liu
previously approved these changes
May 28, 2025
steveburnett
requested changes
May 28, 2025
steveburnett
left a comment
steveburnett
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the doc! One nit, and one request.
…#25210) Summary: Currently, client timeout value is passed via query.client.timeout config property which applies to all queries. Adding corresponding session property which can be used to specify timeout values at query level, if needed. Differential Revision: D75480566
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D75480566 |
feilong-liu
approved these changes
May 28, 2025
steveburnett
approved these changes
May 28, 2025
steveburnett
left a comment
steveburnett
left a comment
Contributor
There was a problem hiding this comment.
LGTM! (docs)
Pull updated branch, new local doc build, looks good.
Thanks for the doc update!
21 tasks
6 tasks
This was referenced Jul 4, 2025
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently, client timeout value is passed via query.client.timeout
config property which applies to all queries. Adding corresponding
session property which can be used to specify timeout values at
query level, if needed.
Differential Revision: D75480566