Fix distributed sort parallelism for single node execution#25022
Merged
Conversation
The AddExchanges optimizer rule is disabled for single node execution. The AddExchanges was responsible for marking the SortNode as partial. When the SortNode is not marked as partial, Velox only runs a single instance of a pipeline containing a SortNode.
rschlussel
approved these changes
May 1, 2025
kewang1024
approved these changes
May 1, 2025
21 tasks
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The AddExchanges optimizer rule is disabled for single node execution. The AddExchanges was responsible for marking the SortNode as partial. When the SortNode is not marked as partial, Velox only runs a single instance of a pipeline containing a SortNode.
Motivation and Context
Improve parallelism for queries running in single node mode containing ORDER BY
Impact
Improved performance for ORDER BY queries running in single node mode
Test Plan
Integration test
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.