Fix: Re-initialize sort key serializer for every new input added#25015
Merged
facebook-github-bot merged 1 commit intoMay 2, 2025
Merged
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 30, 2025
…stodb#25015) Summary: The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
755797a to
a1c0b19
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
xiaoxmeng
approved these changes
Apr 30, 2025
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 30, 2025
…stodb#25015) Summary: The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
a1c0b19 to
0416301
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 30, 2025
…stodb#25015) Summary: The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
0416301 to
5e11e6f
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 30, 2025
…stodb#25015) Summary: Pull Request resolved: prestodb#25015 The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
5e11e6f to
d5e181c
Compare
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 30, 2025
…stodb#25015) Summary: The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
d5e181c to
9d5eddb
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
May 1, 2025
…stodb#25015) Summary: The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
9d5eddb to
583399b
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
Collaborator
|
@emilysun201309 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: The sort key serializer `binarySortableSerializer_` needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data. This diffs move the initialization of `binarySortableSerializer_` to `addInput()` so that the above condition is satisfied. Reviewed By: xiaoxmeng Differential Revision: D73903883
emilysun201309
force-pushed
the
export-D73903883
branch
from
583399b to
48a40fb
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73903883 |
21 tasks
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The sort key serializer
binarySortableSerializer_needs to be initialized for every input batch. Otherwise, we end up re-using only keys from the first batch of data.This diffs move the initialization of
binarySortableSerializer_toaddInput()so that the above condition is satisfied.Reviewed By: xiaoxmeng
Differential Revision: D73903883