Add support for geometry type in mysql connector

[Mariamalmesfer]

Description

Added support for the GEOMETRY type in the MySQL connector.

Motivation and Context

To enable reading geometry data from MySQL tables using Presto.

Impact

Queries with GEOMETRY columns in MySQL will now be supported.

Test Plan

Covered in TestMySqlIntegrationSmokeTest with POINT, LINESTRING, and POLYGON.

Contributor checklist

• Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
• PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
• Documented new properties (with its default value), SQL syntax, functions, or other functionality.
• If release notes are required, they follow the release notes guidelines.
• Adequate tests were added if applicable.
• CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

MYSQL Connector Changes
* Add support for GEOMETRY type in the MySQL connector.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Mariamalmesfer / name: Mariam AlMesfer (62e6371)

[steveburnett]

Do the Type Mapping tables in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/mysql.rst#type-mapping need to be updated with this added type?

[infvg]

Nice work LGTM logic is great just some minor code style suggestions

[prestodb-ci]

@ethanyzhang imported this issue as lakehouse/tracker #24996

[Mariamalmesfer]

Do the Type Mapping tables in https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/connector/mysql.rst#type-mapping need to be updated with this added type?

Yes, I added the required change. The MySQL to PrestoDB type mapping table is updated to include GEOMETRY as VARBINARY

[steveburnett]

LGTM! (docs)

Pull branch, local doc build, looks good.

This updates the table in MySQL to PrestoDB type mapping, but should a similar line be added to the table in PrestoDB to MySQL type mapping?

[Mariamalmesfer]

LGTM! (docs)

Pull branch, local doc build, looks good.

This updates the table in MySQL to PrestoDB type mapping, but should a similar line be added to the table in PrestoDB to MySQL type mapping?

yes I only updated the MySQL to PrestoDB type mapping table. the change only adds read support for GEOMETRY. Since we’re reading it as VARBINARY, it’s not supported for writing

[steveburnett]

yes I only updated the MySQL to PrestoDB type mapping table. the change only adds read support for GEOMETRY. Since we’re reading it as VARBINARY, it’s not supported for writing

Thanks for the explanation! Makes sense.

[steveburnett]

LGTM! (docs)

[ZacBlanco]

I also just realized you are using assertion functions from the assertj library. We use the assertion functions from org.testng. Please replace your usages of assertj with our standard assertion functions.

[Mariamalmesfer]

I also just realized you are using assertion functions from the assertj library. We use the assertion functions from org.testng. Please replace your usages of assertj with our standard assertion functions.

Thanks for pointing that out. Done Ihave updated the assertions functions to use org.testng.Assert.

[ZacBlanco]

LGTM