Use VectorFuzzer for BinarySortableSerializer test#24954
Merged
facebook-github-bot merged 1 commit intoApr 25, 2025
Conversation
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73075362 |
Contributor
|
Thanks for the release note! Nit: |
xiaoxmeng
approved these changes
Apr 23, 2025
emilysun201309
added a commit
to emilysun201309/presto
that referenced
this pull request
Apr 23, 2025
Summary: - Use VectorFuzzer for test so that we can generate larger input data. - These tests work by first using OrderBy operator in Velox to sort the input data. Then serialize the sorted result, and ensure that the sorting order is preserved after serialization. Reviewed By: xiaoxmeng Differential Revision: D73075362
emilysun201309
force-pushed
the
export-D73075362
branch
from
1c3bb0e to
4b5ab1b
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73075362 |
Summary: - Use VectorFuzzer for test so that we can generate larger input data. - These tests work by first using OrderBy operator in Velox to sort the input data. Then serialize the sorted result, and ensure that the sorting order is preserved after serialization. Reviewed By: xiaoxmeng Differential Revision: D73075362
emilysun201309
force-pushed
the
export-D73075362
branch
from
4b5ab1b to
49575be
Compare
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D73075362 |
AnuragKDwivedi
pushed a commit
to AnuragKDwivedi/presto-1
that referenced
this pull request
May 2, 2025
Summary: - Use VectorFuzzer for test so that we can generate larger input data. - These tests work by first using OrderBy operator in Velox to sort the input data. Then serialize the sorted result, and ensure that the sorting order is preserved after serialization. Reviewed By: xiaoxmeng Differential Revision: D73075362
21 tasks
This was referenced May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reviewed By: xiaoxmeng
Differential Revision: D73075362