fix: Feature environment variable should override environment variables in default activation.env #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attler_shell crate
… export task.env().
…nvironment variable'
magentaqin
changed the title
lucascolley
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix: #4116
What I changed
As
self.features()would put "default" envs in the last item, but the "default" env priority should be the lowest.Here, we userfold(reverse fold) to ensure later features override earlier features for environment variables. Processing features in reverse order means that features appearing later in the list will have higher precedence.Example: If features:
[override_feature, user_feature, default]rfold processes as:
[default, user_feature, override_feature]Result:
override_featureenv vars take precedence over all others.Code Details: https://github.com/prefix-dev/pixi/pull/4182/files#diff-a2d90b46ebb3debf0ba9dc9798401cf42ecd31371adddfd3849bf8758f0dfe20
Notice
This PR should be merged after #3940 is merged, as I worked based on the previous feature branch(My original thought was to avoid unnecessary conflicts resolving.)