feat(init): support --import with --format pyproject
#4134
Conversation
…rror - produces a valid pyproject.toml file, probably not yet complete
|
I'll review this after gh-4096 is merged. |
|
will this also close gh-3499? |
lucascolley
changed the title
init --import enviornment.yml --format pyproject now runs without error--import with --format pyproject
There was a problem hiding this comment.
thanks @telamonian, looks like a good start!
Please could you add some tests, following the style of https://github.com/prefix-dev/pixi/blob/main/tests/integration_python/test_import.py ? I think one test for a successful import and one test for the user dialog would be a good start, we can add some more later. Don't worry about including any snapshots in the tests yet though, we are in the process of updating our contributor guidance for that.
| } else { | ||
| config.default_channels().to_vec() | ||
| }; | ||
| // Check if the 'pixi.toml' file doesn't already exist. We don't want to |
There was a problem hiding this comment.
| // Check if the 'pixi.toml' file doesn't already exist. We don't want to | |
| // Check that the 'pixi.toml' file doesn't already exist. We don't want to |
| eprintln!( | ||
| "\nA '{}' file already exists.\n", | ||
| console::style(consts::PYPROJECT_MANIFEST).bold() | ||
| "{}Created {}", | ||
| console::style(console::Emoji("✔ ", "")).green(), | ||
| // Canonicalize the path to make it more readable, but if it fails just use the path as | ||
| // is. | ||
| workspace.workspace.provenance.path.display() |
There was a problem hiding this comment.
I think we want to include this in the pyproject path also?
| .map(|name| name.as_dist_info_name().to_string()) | ||
| .unwrap_or_else(|_| name.clone()); | ||
|
|
||
| let rv = env |
There was a problem hiding this comment.
what does rv stand for?
| format!("Could not create file {}.", init_file.display()) | ||
| }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
have I missed something, or does the pyproject path not use (conda_deps, pypi_deps) from above? If so, I think import will not work properly.
fixes #2523
Done at SciPy sprints 2025! @wolfv @ruben-arts
Currently produces a valid pyproject.toml file, probably not yet complete. There's kind of a tangle of conditionals in
init.rs, so we should probably have a conversation about intended behavior.Might also have some overlap with #4096