Merged
Conversation
Member
|
Can you please also document this on the contributing guidelines? |
Member
Author
|
@MakisH should we make this optional or mandatory? |
fsimonis
force-pushed
the
add-hook-to-check-image-names
branch
from
59e4b8f to
e3c0a6d
Compare
MakisH
approved these changes
Mar 8, 2024
Member
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Feel free to merge once it is documented.
This is definitely a nice check!
Member
Author
|
I opened the RP for the documentation. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit hook that checks if the names of images in
A/images/are correctly prefixed.The required prefix is:
tutorial-<A>-orquickstart-ifAisquickstart.This is required to prevent conflicts in the website assets folder.