Conversation
MakisH
reviewed
Mar 26, 2024
Member
MakisH
left a comment
There was a problem hiding this comment.
Basic sanity check makes sense. I will approve when the final versions are there.
Member
Author
Member
|
No: the versions will then always need to be updated, and they will be duplicated. I find TODOs better for this template. |
Member
Author
|
we could also leave the versions of the current distribution and document that this is an example and needs to be updated before using. |
Member
Author
|
I now added the versions and a bit of documentation. Simply saves me one TODO when I need to actually apply the script. |
uekerman
commented
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we have no good place yet where to upload the scripts and the scripts need manual editing anyway, I thought adding them in plain text here could be a good compromise.
The actual component versions still need final updates.
@MakisH No need to test anything. A quick check should be enough. I will anyway "test this" with the real data.
Thanks @JR-1991 for the help setting this up 🙏 Should be added as a co-author here when merging.