Provide diff with all changes in step-by-step example.#262
Provide diff with all changes in step-by-step example.#262BenjaminRodenberg merged 26 commits intomasterfrom
Conversation
uekerman
left a comment
There was a problem hiding this comment.
I like this idea. My suggestion would be to move this code part at the bottom and explain all individual steps one-by-one above (not in this PR).
No idea about the code split. Seems like we should do this.
|
Related to #260 |
fsimonis
left a comment
There was a problem hiding this comment.
Can't we changes these to std::vector now?
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
Co-authored-by: Frédéric Simonis <simonisfrederic@gmail.com>
MakisH
left a comment
There was a problem hiding this comment.
Looks really nice, and very helpful, thank you!
I have not cross-checked with the latest state of the API, but the changes make sense compared to what I remember from the last time I checked.
|
|
||
| ## preCICE API | ||
|
|
||
| <!-- Split code block. See https://github.com/precice/precice.github.io/commit/74e377cece4a221e00b5c56b1db3942ec70a6272. --> |
There was a problem hiding this comment.
@MakisH Do you have more details on this point? If it is simple: Let's do it now. If it is more complicated: I guess it's not critical and we can just merge.
There was a problem hiding this comment.
I do not understand what you mean. Could you please elaborate what the problem is? I vaguely remember some issue with code highlighting in diff. Normal diff should work.
There was a problem hiding this comment.
I just prepared this for my thesis and thought it might also be useful for the documentation. It's unfortunately quite lenghty, but there are also many changes. I'm open for suggestions!
Todo
Split code block. See 74e377c. @uekerman , @fsimonis any guidelines?Does not look critical to me. We can also fix this later, if necessary.