Skip to content

optable-targeting: update macros, fail early if tenant and origin are not configured #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

justadreamer
Copy link
Contributor

🔧 Type of changes

  • bugfix

✨ What's the context?

Macros in the endpoint URL should be enclosed into double curly bracket '{{}}', not single '{}'. Also if tenant or origin are not provided in the account configuration the hook fails early with a 1% error logging rate.

🧠 Rationale behind the change

A requirement to macros to potentially prevent syntax collisions. Also if account is misconfigured to not include tenant or origin params - these are mandatory - the hook fails early with appropriate error message with 1% error logging rate.

🧪 Test plan

Unit tests + ran manual integration testing.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code? - Yes it will require a change of host configuration slightly - they will have to use {{}} to enclose the macros - need to update the docs

@osulzhenko osulzhenko requested a review from CTMBNara August 12, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants