optable-targeting: update macros, fail early if tenant and origin are not configured #4131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Macros in the endpoint URL should be enclosed into double curly bracket '{{}}', not single '{}'. Also if tenant or origin are not provided in the account configuration the hook fails early with a 1% error logging rate.
🧠 Rationale behind the change
A requirement to macros to potentially prevent syntax collisions. Also if account is misconfigured to not include tenant or origin params - these are mandatory - the hook fails early with appropriate error message with 1% error logging rate.
🧪 Test plan
Unit tests + ran manual integration testing.
🏎 Quality check