Skip to content

Fix Error Metrics Firing Twice #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Error Metrics Firing Twice #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/main/java/org/prebid/cache/handlers/cache/CacheHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import org.springframework.web.reactive.function.server.ServerRequest;
import org.springframework.web.reactive.function.server.ServerResponse;
import reactor.core.publisher.Mono;
import reactor.core.publisher.Signal;

import java.util.concurrent.TimeoutException;

Expand Down Expand Up @@ -90,13 +89,12 @@ private Mono<ServerResponse> handleErrorMetrics(final Throwable error, final Ser
}

return builder.error(Mono.just(error), request)
.doOnEach(signal -> handleErrorStatusCodes(request, signal));
.doOnNext(response -> handleErrorStatusCodes(request, response));
}

private void handleErrorStatusCodes(ServerRequest request, Signal<ServerResponse> signal) {
final var response = signal.get();
HttpMethod method = request.method();
if (method == null || signal.isOnError() || response == null) {
private void handleErrorStatusCodes(ServerRequest request, ServerResponse response) {
final HttpMethod method = request.method();
if (method == null || response == null) {
recordMetric(MeasurementTag.ERROR_UNKNOWN);
} else if (response.statusCode() == HttpStatus.INTERNAL_SERVER_ERROR) {
recordMetric(MeasurementTag.ERROR_UNKNOWN);
Expand Down
Loading