-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Description
Twist, shine, tagoras, and kueez should all make use of vidazoo utilities for improved code maintainability
Cc @uditalias
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
modules/twistDigitalBidAdapter.jshas 18 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 30 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 19 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 45 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 13 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 31 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 73 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 14 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 25 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 15 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/twistDigitalBidAdapter.jshas 10 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/tagorasBidAdapter.jshas 14 duplicated lines withmodules/twistDigitalBidAdapter.jsmodules/tagorasBidAdapter.jshas 15 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/tagorasBidAdapter.jshas 31 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/tagorasBidAdapter.jshas 31 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/tagorasBidAdapter.jshas 31 duplicated lines withmodules/twistDigitalBidAdapter.jsmodules/tagorasBidAdapter.jshas 40 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/tagorasBidAdapter.jshas 9 duplicated lines withmodules/twistDigitalBidAdapter.jsmodules/tagorasBidAdapter.jshas 61 duplicated lines withmodules/twistDigitalBidAdapter.jsmodules/shinezRtbBidAdapter.jshas 19 duplicated lines withlibraries/vidazooUtils/bidderUtils.jsmodules/shinezRtbBidAdapter.jshas 92 duplicated lines withmodules/twistDigitalBidAdapter.jsmodules/kueezRtbBidAdapter.jshas 32 duplicated lines withlibraries/vidazooUtils/bidderUtils.js
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. Keep up the great work! 🚀
Originally posted by @github-actions[bot] in #11821 (comment)
uditalias
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done