Skip to content

refactor: simplify toChildArray guards - #5214

Merged
JoviDeCroock merged 2 commits into
mainfrom
agent/simplify-to-child-array
Aug 24, 2026
Merged

refactor: simplify toChildArray guards#5214
JoviDeCroock merged 2 commits into
mainfrom
agent/simplify-to-child-array

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented Aug 24, 2026

Copy link
Copy Markdown
Member

Simplify toChildArray's null and boolean filter to a positive guard, reducing the compressed core bundle size while preserving child normalization behavior.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -1% - +1% (-8.84ms - +12.31ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -4% - +2% (-0.61ms - +0.41ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +5% (-0.31ms - +2.16ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -3% - +2% (-0.46ms - +0.31ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.30ms - +0.68ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.11ms - +0.09ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +2% (-0.73ms - +0.63ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +1% (-1.43ms - +0.35ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-0.10ms - +0.10ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • text-update: slower ❌ 0% - 6% (0.00ms - 0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local823.33ms - 841.71ms-unsure 🔍
-1% - +1%
-8.84ms - +12.31ms
preact-main825.56ms - 836.01msunsure 🔍
-1% - +1%
-12.31ms - +8.84ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.09ms - 19.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.09ms - 19.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.94ms-unsure 🔍
-4% - +2%
-0.61ms - +0.41ms
preact-main16.38ms - 17.33msunsure 🔍
-2% - +4%
-0.41ms - +0.61ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.57ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main1.57ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local46.92ms - 48.66ms-unsure 🔍
-1% - +5%
-0.31ms - +2.16ms
preact-main46.00ms - 47.74msunsure 🔍
-4% - +1%
-2.16ms - +0.31ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local4.98ms - 5.12ms-unsure 🔍
-2% - +2%
-0.10ms - +0.10ms
preact-main4.98ms - 5.12msunsure 🔍
-2% - +2%
-0.10ms - +0.10ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.25ms - 16.60ms-unsure 🔍
-3% - +2%
-0.46ms - +0.31ms
preact-main16.16ms - 16.84msunsure 🔍
-2% - +3%
-0.31ms - +0.46ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5849
  • Commit: b481a31

duration

VersionAvg timevs preact-localvs preact-main
preact-local54.67ms - 55.39ms-unsure 🔍
-1% - +1%
-0.30ms - +0.68ms
preact-main54.51ms - 55.17msunsure 🔍
-1% - +1%
-0.68ms - +0.30ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.03ms - 3.03ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.03ms - 3.03msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.11ms - 25.74ms-unsure 🔍
-2% - +2%
-0.40ms - +0.58ms
preact-main24.96ms - 25.71msunsure 🔍
-2% - +2%
-0.58ms - +0.40ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local28.84ms - 29.87ms-unsure 🔍
-1% - +3%
-0.38ms - +0.98ms
preact-main28.61ms - 29.51msunsure 🔍
-3% - +1%
-0.98ms - +0.38ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.93ms - 30.26ms-unsure 🔍
-2% - +4%
-0.54ms - +1.22ms
preact-main28.68ms - 29.83msunsure 🔍
-4% - +2%
-1.22ms - +0.54ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.11ms - 24.34ms-unsure 🔍
-1% - +0%
-0.23ms - +0.11ms
preact-main24.16ms - 24.42msunsure 🔍
-0% - +1%
-0.11ms - +0.23ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.84ms - 26.66ms-unsure 🔍
-2% - +2%
-0.54ms - +0.64ms
preact-main25.77ms - 26.63msunsure 🔍
-2% - +2%
-0.64ms - +0.54ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local19.66ms - 19.97ms-unsure 🔍
-1% - +2%
-0.19ms - +0.31ms
preact-main19.56ms - 19.94msunsure 🔍
-2% - +1%
-0.31ms - +0.19ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 210
  • Built by: CI #5849
  • Commit: b481a31

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.00ms - 2.15ms-unsure 🔍
-5% - +4%
-0.11ms - +0.09ms
preact-main2.01ms - 2.15msunsure 🔍
-4% - +5%
-0.09ms - +0.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.04ms - 1.09ms-slower ❌
0% - 6%
0.00ms - 0.06ms
preact-main1.01ms - 1.05msfaster ✔
0% - 6%
0.00ms - 0.06ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.63ms - 30.44ms-unsure 🔍
-2% - +2%
-0.73ms - +0.63ms
preact-main29.55ms - 30.62msunsure 🔍
-2% - +2%
-0.63ms - +0.73ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.82ms - 29.92ms-unsure 🔍
-5% - +1%
-1.43ms - +0.35ms
preact-main29.21ms - 30.61msunsure 🔍
-1% - +5%
-0.35ms - +1.43ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.99ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.98ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Size Change: -4 B (-0.03%)

Total Size: 15.8 kB

📦 View Changed
Filename Size Change
dist/preact.mjs 4.88 kB -4 B (-0.08%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.9 kB
debug/dist/debug.mjs 3.88 kB
devtools/dist/devtools.mjs 272 B
hooks/dist/hooks.mjs 1.55 kB
jsx-runtime/dist/jsxRuntime.mjs 856 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Aug 24, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 99.533%. remained the same — agent/simplify-to-child-array into main

@JoviDeCroock
JoviDeCroock marked this pull request as ready for review August 24, 2026 13:24
@JoviDeCroock
JoviDeCroock marked this pull request as draft August 24, 2026 13:25
@JoviDeCroock
JoviDeCroock marked this pull request as ready for review August 24, 2026 13:28
@JoviDeCroock
JoviDeCroock merged commit 0fd9a02 into main Aug 24, 2026
12 checks passed
@JoviDeCroock
JoviDeCroock deleted the agent/simplify-to-child-array branch August 24, 2026 15:37
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants