Skip to content

perf(hooks): remove unused memo factory state - #5213

Merged
JoviDeCroock merged 3 commits into
mainfrom
agent/remove-unused-memo-factory
Aug 24, 2026
Merged

perf(hooks): remove unused memo factory state#5213
JoviDeCroock merged 3 commits into
mainfrom
agent/remove-unused-memo-factory

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Remove the unused useMemo factory reference from memo hook state. This eliminates a hot-path property write and reduces the hooks bundle by 8 B raw / 4 B gzip / 6 B Brotli.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-7.04ms - +3.55ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.10ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +2% (-1.04ms - +1.02ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +1% (-0.75ms - +0.22ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +3% (-0.43ms - +1.56ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +4% (-0.12ms - +0.07ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +0% (-0.96ms - +0.04ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-0.88ms - +0.64ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +5% (-0.01ms - +0.23ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • text-update: faster ✔ 1% - 10% (0.01ms - 0.11ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local840.28ms - 847.16ms-unsure 🔍
-1% - +0%
-7.04ms - +3.55ms
preact-main841.45ms - 849.49msunsure 🔍
-0% - +1%
-3.55ms - +7.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.09ms - 19.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.09ms - 19.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.73ms-unsure 🔍
-1% - +1%
-0.10ms - +0.12ms
preact-main16.56ms - 16.72msunsure 🔍
-1% - +1%
-0.12ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.57ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local54.26ms - 55.96ms-unsure 🔍
-2% - +2%
-1.04ms - +1.02ms
preact-main54.55ms - 55.71msunsure 🔍
-2% - +2%
-1.02ms - +1.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.01ms - 5.25ms-unsure 🔍
-0% - +5%
-0.01ms - +0.23ms
preact-main5.02ms - 5.03msunsure 🔍
-4% - +0%
-0.23ms - +0.01ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.09ms - 16.40ms-unsure 🔍
-4% - +1%
-0.75ms - +0.22ms
preact-main16.06ms - 16.97msunsure 🔍
-1% - +5%
-0.22ms - +0.75ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.76ms - 3.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #5851
  • Commit: 8eadf19

duration

VersionAvg timevs preact-localvs preact-main
preact-local50.33ms - 51.77ms-unsure 🔍
-1% - +3%
-0.43ms - +1.56ms
preact-main49.80ms - 51.17msunsure 🔍
-3% - +1%
-1.56ms - +0.43ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.05ms - 3.06ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main3.05ms - 3.07msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local21.14ms - 21.73ms-unsure 🔍
-3% - +1%
-0.67ms - +0.20ms
preact-main21.35ms - 21.99msunsure 🔍
-1% - +3%
-0.20ms - +0.67ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local26.03ms - 26.84ms-unsure 🔍
-2% - +3%
-0.43ms - +0.69ms
preact-main25.91ms - 26.69msunsure 🔍
-3% - +2%
-0.69ms - +0.43ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.65ms - 26.61ms-unsure 🔍
-5% - +0%
-1.33ms - +0.08ms
preact-main26.24ms - 27.28msunsure 🔍
-0% - +5%
-0.08ms - +1.33ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local21.02ms - 21.84ms-unsure 🔍
-2% - +3%
-0.33ms - +0.59ms
preact-main21.08ms - 21.52msunsure 🔍
-3% - +2%
-0.59ms - +0.33ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local21.56ms - 22.43ms-unsure 🔍
-3% - +3%
-0.56ms - +0.61ms
preact-main21.57ms - 22.36msunsure 🔍
-3% - +3%
-0.61ms - +0.56ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local18.47ms - 18.93ms-unsure 🔍
-1% - +3%
-0.11ms - +0.48ms
preact-main18.33ms - 18.70msunsure 🔍
-3% - +1%
-0.48ms - +0.11ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 210
  • Built by: CI #5851
  • Commit: 8eadf19

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.97ms - 2.09ms-unsure 🔍
-6% - +4%
-0.12ms - +0.07ms
preact-main1.98ms - 2.12msunsure 🔍
-4% - +6%
-0.07ms - +0.12ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.05ms - 1.11ms-faster ✔
1% - 10%
0.01ms - 0.11ms
preact-main1.10ms - 1.19msslower ❌
1% - 11%
0.01ms - 0.11ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.82ms - 30.09ms-unsure 🔍
-3% - +0%
-0.96ms - +0.04ms
preact-main29.94ms - 30.90msunsure 🔍
-0% - +3%
-0.04ms - +0.96ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k
  • Browser: chrome-headless
  • Sample size: 130
  • Built by: CI #5851
  • Commit: 8eadf19

duration

VersionAvg timevs preact-localvs preact-main
preact-local21.18ms - 22.24ms-unsure 🔍
-4% - +3%
-0.88ms - +0.64ms
preact-main21.29ms - 22.37msunsure 🔍
-3% - +4%
-0.64ms - +0.88ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.97ms - 2.98msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

Size Change: -5 B (-0.03%)

Total Size: 15.8 kB

📦 View Changed
Filename Size Change
hooks/dist/hooks.mjs 1.55 kB -5 B (-0.32%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.9 kB
debug/dist/debug.mjs 3.88 kB
devtools/dist/devtools.mjs 272 B
dist/preact.mjs 4.88 kB
jsx-runtime/dist/jsxRuntime.mjs 856 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Aug 24, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 99.533%. remained the same — agent/remove-unused-memo-factory into main

@JoviDeCroock
JoviDeCroock marked this pull request as ready for review August 24, 2026 13:24
@JoviDeCroock
JoviDeCroock marked this pull request as draft August 24, 2026 13:25
@JoviDeCroock
JoviDeCroock marked this pull request as ready for review August 24, 2026 13:29
@JoviDeCroock
JoviDeCroock merged commit 595625e into main Aug 24, 2026
13 checks passed
@JoviDeCroock
JoviDeCroock deleted the agent/remove-unused-memo-factory branch August 24, 2026 15:36
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants