Skip to content

refactor(compat): remove redundant textarea hydration hook - #5212

Merged
JoviDeCroock merged 2 commits into
mainfrom
agent/remove-compat-textarea-diffed
Aug 24, 2026
Merged

refactor(compat): remove redundant textarea hydration hook#5212
JoviDeCroock merged 2 commits into
mainfrom
agent/remove-compat-textarea-diffed

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Core now synchronizes textarea values during hydration, so compat no longer needs its diffed hook. Coverage exercises a core hydration mismatch and nullish uncontrolled compat textareas across hydration and rerenders.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -1% - +1% (-4.34ms - +9.22ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.22ms - +0.10ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-1.64ms - +0.93ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -5% - +2% (-0.83ms - +0.31ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.32ms - +0.73ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.09ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +5% (-0.04ms - +1.56ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +4% (-1.35ms - +1.42ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-0.19ms - +0.12ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +3% (-0.05ms - +0.03ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local835.21ms - 846.45ms-unsure 🔍
-1% - +1%
-4.34ms - +9.22ms
preact-main834.59ms - 842.18msunsure 🔍
-1% - +1%
-9.22ms - +4.34ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.09ms - 19.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.09ms - 19.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 16.60ms-unsure 🔍
-1% - +1%
-0.22ms - +0.10ms
preact-main16.47ms - 16.80msunsure 🔍
-1% - +1%
-0.10ms - +0.22ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.58ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.57ms - 1.58msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local56.20ms - 57.60ms-unsure 🔍
-3% - +2%
-1.64ms - +0.93ms
preact-main56.18ms - 58.33msunsure 🔍
-2% - +3%
-0.93ms - +1.64ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.00ms - 5.19ms-unsure 🔍
-4% - +2%
-0.19ms - +0.12ms
preact-main5.01ms - 5.24msunsure 🔍
-2% - +4%
-0.12ms - +0.19ms
-
many-updates
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5842
  • Commit: a250eb5

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.59ms - 17.30ms-unsure 🔍
-5% - +2%
-0.83ms - +0.31ms
preact-main16.76ms - 17.65msunsure 🔍
-2% - +5%
-0.31ms - +0.83ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.75msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5842
  • Commit: a250eb5

duration

VersionAvg timevs preact-localvs preact-main
preact-local55.11ms - 56.63ms-unsure 🔍
-2% - +1%
-1.32ms - +0.73ms
preact-main55.48ms - 56.85msunsure 🔍
-1% - +2%
-0.73ms - +1.32ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.03ms - 3.03ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.03ms - 3.03msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.03ms - 28.11ms-unsure 🔍
-1% - +4%
-0.25ms - +1.03ms
preact-main26.83ms - 27.54msunsure 🔍
-4% - +1%
-1.03ms - +0.25ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local30.93ms - 32.24ms-unsure 🔍
-5% - +0%
-1.68ms - +0.15ms
preact-main31.71ms - 32.99msunsure 🔍
-1% - +5%
-0.15ms - +1.68ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.53ms - 32.12ms-unsure 🔍
-3% - +3%
-1.05ms - +1.07ms
preact-main30.61ms - 32.02msunsure 🔍
-3% - +3%
-1.07ms - +1.05ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.31ms - 25.91ms-unsure 🔍
-1% - +2%
-0.18ms - +0.48ms
preact-main25.33ms - 25.59msunsure 🔍
-2% - +1%
-0.48ms - +0.18ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local27.11ms - 28.04ms-unsure 🔍
-1% - +4%
-0.40ms - +0.96ms
preact-main26.79ms - 27.79msunsure 🔍
-3% - +1%
-0.96ms - +0.40ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.67ms - 21.20ms-unsure 🔍
-1% - +2%
-0.17ms - +0.47ms
preact-main20.60ms - 20.96msunsure 🔍
-2% - +1%
-0.47ms - +0.17ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 170
  • Built by: CI #5842
  • Commit: a250eb5

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.89ms - 2.03ms-unsure 🔍
-5% - +4%
-0.09ms - +0.08ms
preact-main1.91ms - 2.02msunsure 🔍
-4% - +5%
-0.08ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.04ms - 1.10ms-unsure 🔍
-5% - +3%
-0.05ms - +0.03ms
preact-main1.05ms - 1.11msunsure 🔍
-3% - +5%
-0.03ms - +0.05ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.06ms - 33.63ms-unsure 🔍
-0% - +5%
-0.04ms - +1.56ms
preact-main31.93ms - 32.24msunsure 🔍
-5% - +0%
-1.56ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.45ms - 33.43ms-unsure 🔍
-4% - +4%
-1.35ms - +1.42ms
preact-main31.43ms - 33.37msunsure 🔍
-4% - +4%
-1.42ms - +1.35ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main2.97ms - 2.98msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@github-actions

Copy link
Copy Markdown

Size Change: -53 B (-0.33%)

Total Size: 15.8 kB

📦 View Changed
Filename Size Change
compat/dist/compat.mjs 3.9 kB -53 B (-1.34%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.mjs 3.88 kB
devtools/dist/devtools.mjs 272 B
dist/preact.mjs 4.88 kB
hooks/dist/hooks.mjs 1.56 kB
jsx-runtime/dist/jsxRuntime.mjs 856 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Aug 24, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 99.533% (+0.9%) from 98.654% — agent/remove-compat-textarea-diffed into main

@JoviDeCroock
JoviDeCroock merged commit 56a649f into main Aug 24, 2026
13 checks passed
@JoviDeCroock
JoviDeCroock deleted the agent/remove-compat-textarea-diffed branch August 24, 2026 13:01
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants