Skip to content

test: cover JSX refs and event bubbling - #5211

Merged
JoviDeCroock merged 2 commits into
mainfrom
agent/add-coverage-regressions
Aug 24, 2026
Merged

test: cover JSX refs and event bubbling#5211
JoviDeCroock merged 2 commits into
mainfrom
agent/add-coverage-regressions

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Adds regression coverage for intrinsic JSX refs and event handlers attached during bubbling. Aligns debug captureOwnerStack with its nullable public contract.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -1% - +0% (-6.98ms - +2.29ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.10ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +2% (-1.54ms - +1.29ms)
    preact-local vs preact-main
  • many-updates: slower ❌ 0% - 6% (0.07ms - 0.92ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +2% (-0.59ms - +1.35ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -7% - +2% (-0.14ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +4% (-0.34ms - +1.14ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +4% (-1.33ms - +1.07ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +5% (-0.18ms - +0.25ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +6% (-0.03ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local836.24ms - 842.50ms-unsure 🔍
-1% - +0%
-6.98ms - +2.29ms
preact-main838.29ms - 845.14msunsure 🔍
-0% - +1%
-2.29ms - +6.98ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.09ms - 19.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.09ms - 19.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.46ms - 16.57ms-unsure 🔍
-1% - +0%
-0.10ms - +0.02ms
preact-main16.53ms - 16.58msunsure 🔍
-0% - +1%
-0.02ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.57ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.57ms - 1.57msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local54.67ms - 56.49ms-unsure 🔍
-3% - +2%
-1.54ms - +1.29ms
preact-main54.62ms - 56.80msunsure 🔍
-2% - +3%
-1.29ms - +1.54ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.05ms - 5.36ms-unsure 🔍
-3% - +5%
-0.18ms - +0.25ms
preact-main5.03ms - 5.31msunsure 🔍
-5% - +3%
-0.25ms - +0.18ms
-
many-updates
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5841
  • Commit: 276f0cf

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.42ms - 17.18ms-slower ❌
0% - 6%
0.07ms - 0.92ms
preact-main16.11ms - 16.50msfaster ✔
0% - 5%
0.07ms - 0.92ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.76ms - 3.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5841
  • Commit: 276f0cf

duration

VersionAvg timevs preact-localvs preact-main
preact-local56.00ms - 57.50ms-unsure 🔍
-1% - +2%
-0.59ms - +1.35ms
preact-main55.75ms - 56.98msunsure 🔍
-2% - +1%
-1.35ms - +0.59ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.03ms - 3.04ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.03ms - 3.03msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local26.92ms - 27.83ms-unsure 🔍
-2% - +3%
-0.53ms - +0.77ms
preact-main26.79ms - 27.72msunsure 🔍
-3% - +2%
-0.77ms - +0.53ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.82ms - 33.12ms-unsure 🔍
-3% - +3%
-0.94ms - +0.90ms
preact-main31.84ms - 33.15msunsure 🔍
-3% - +3%
-0.90ms - +0.94ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local32.02ms - 33.68ms-unsure 🔍
-2% - +5%
-0.60ms - +1.75ms
preact-main31.45ms - 33.10msunsure 🔍
-5% - +2%
-1.75ms - +0.60ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.10ms - 26.49ms-unsure 🔍
-1% - +1%
-0.28ms - +0.20ms
preact-main26.19ms - 26.47msunsure 🔍
-1% - +1%
-0.20ms - +0.28ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local27.01ms - 28.40ms-unsure 🔍
-2% - +4%
-0.61ms - +1.00ms
preact-main27.10ms - 27.91msunsure 🔍
-4% - +2%
-1.00ms - +0.61ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.44ms - 22.07ms-unsure 🔍
-2% - +2%
-0.40ms - +0.41ms
preact-main21.49ms - 22.01msunsure 🔍
-2% - +2%
-0.41ms - +0.40ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 210
  • Built by: CI #5841
  • Commit: 276f0cf

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.95ms - 2.07ms-unsure 🔍
-7% - +2%
-0.14ms - +0.04ms
preact-main1.99ms - 2.12msunsure 🔍
-2% - +7%
-0.04ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.07ms - 1.13ms-unsure 🔍
-3% - +6%
-0.03ms - +0.06ms
preact-main1.05ms - 1.11msunsure 🔍
-6% - +3%
-0.06ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.37ms - 33.72ms-unsure 🔍
-1% - +4%
-0.34ms - +1.14ms
preact-main32.34ms - 32.95msunsure 🔍
-3% - +1%
-1.14ms - +0.34ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local28.71ms - 30.48ms-unsure 🔍
-4% - +4%
-1.33ms - +1.07ms
preact-main28.91ms - 30.54msunsure 🔍
-4% - +5%
-1.07ms - +1.33ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.97ms - 2.98msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions

Copy link
Copy Markdown

Size Change: +9 B (+0.06%)

Total Size: 15.9 kB

📦 View Changed
Filename Size Change
debug/dist/debug.mjs 3.88 kB +9 B (+0.23%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.95 kB
devtools/dist/devtools.mjs 272 B
dist/preact.mjs 4.88 kB
hooks/dist/hooks.mjs 1.56 kB
jsx-runtime/dist/jsxRuntime.mjs 856 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Aug 24, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 98.654% (+0.05%) from 98.606% — agent/add-coverage-regressions into main

@JoviDeCroock
JoviDeCroock merged commit 8ed1471 into main Aug 24, 2026
12 checks passed
@JoviDeCroock
JoviDeCroock deleted the agent/add-coverage-regressions branch August 24, 2026 12:56
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants