Skip to content

refactor(debug): require prop type stack getter - #5210

Merged
JoviDeCroock merged 1 commit into
mainfrom
agent/simplify-check-props-stack
Aug 24, 2026
Merged

refactor(debug): require prop type stack getter#5210
JoviDeCroock merged 1 commit into
mainfrom
agent/simplify-check-props-stack

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Require the internal PropTypes stack getter and remove the unreachable fallback from debug error output.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-5.67ms - +6.88ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.09ms - +0.12ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +2% (-2.14ms - +0.86ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -5% - +2% (-0.83ms - +0.33ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +3% (-0.63ms - +1.62ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +7% (-0.02ms - +0.13ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -4% - +1% (-0.88ms - +0.15ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +4% (-1.11ms - +1.16ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +4% (-0.12ms - +0.20ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.03ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local800.65ms - 810.78ms-unsure 🔍
-1% - +1%
-5.67ms - +6.88ms
preact-main801.40ms - 808.82msunsure 🔍
-1% - +1%
-6.88ms - +5.67ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.09ms - 19.09ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.09ms - 19.09msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.53ms - 16.70ms-unsure 🔍
-1% - +1%
-0.09ms - +0.12ms
preact-main16.53ms - 16.66msunsure 🔍
-1% - +1%
-0.12ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.57ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.57ms - 1.57msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local43.04ms - 44.93ms-unsure 🔍
-5% - +2%
-2.14ms - +0.86ms
preact-main43.46ms - 45.78msunsure 🔍
-2% - +5%
-0.86ms - +2.14ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.00ms - 5.26ms-unsure 🔍
-2% - +4%
-0.12ms - +0.20ms
preact-main4.99ms - 5.19msunsure 🔍
-4% - +2%
-0.20ms - +0.12ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.35ms - 17.01ms-unsure 🔍
-5% - +2%
-0.83ms - +0.33ms
preact-main16.46ms - 17.40msunsure 🔍
-2% - +5%
-0.33ms - +0.83ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5840
  • Commit: 0ebd5ca

duration

VersionAvg timevs preact-localvs preact-main
preact-local51.73ms - 53.64ms-unsure 🔍
-1% - +3%
-0.63ms - +1.62ms
preact-main51.59ms - 52.79msunsure 🔍
-3% - +1%
-1.62ms - +0.63ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.03ms - 3.03ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main3.03ms - 3.03msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.71ms - 26.45ms-unsure 🔍
-3% - +3%
-0.70ms - +0.66ms
preact-main25.53ms - 26.67msunsure 🔍
-3% - +3%
-0.66ms - +0.70ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local30.05ms - 31.47ms-unsure 🔍
-1% - +6%
-0.17ms - +1.73ms
preact-main29.35ms - 30.62msunsure 🔍
-6% - +1%
-1.73ms - +0.17ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.59ms - 31.15ms-unsure 🔍
-3% - +4%
-0.99ms - +1.20ms
preact-main29.49ms - 31.03msunsure 🔍
-4% - +3%
-1.20ms - +0.99ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.22ms - 24.65ms-unsure 🔍
-2% - +1%
-0.41ms - +0.25ms
preact-main24.27ms - 24.76msunsure 🔍
-1% - +2%
-0.25ms - +0.41ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.18ms - 27.10ms-unsure 🔍
-1% - +4%
-0.30ms - +0.99ms
preact-main25.85ms - 26.75msunsure 🔍
-4% - +1%
-0.99ms - +0.30ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local19.67ms - 20.38ms-unsure 🔍
-2% - +3%
-0.30ms - +0.55ms
preact-main19.67ms - 20.14msunsure 🔍
-3% - +2%
-0.55ms - +0.30ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 210
  • Built by: CI #5840
  • Commit: 0ebd5ca

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.77ms - 1.89ms-unsure 🔍
-1% - +7%
-0.02ms - +0.13ms
preact-main1.73ms - 1.83msunsure 🔍
-7% - +1%
-0.13ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.05ms - 1.11ms-unsure 🔍
-3% - +5%
-0.03ms - +0.05ms
preact-main1.04ms - 1.10msunsure 🔍
-5% - +3%
-0.05ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local23.25ms - 23.59ms-unsure 🔍
-4% - +1%
-0.88ms - +0.15ms
preact-main23.30ms - 24.27msunsure 🔍
-1% - +4%
-0.15ms - +0.88ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.39ms - 30.90ms-unsure 🔍
-4% - +4%
-1.11ms - +1.16ms
preact-main29.27ms - 30.96msunsure 🔍
-4% - +4%
-1.16ms - +1.11ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.99ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.98ms - 2.99msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions

Copy link
Copy Markdown

Size Change: -6 B (-0.04%)

Total Size: 15.9 kB

📦 View Changed
Filename Size Change
debug/dist/debug.mjs 3.87 kB -6 B (-0.15%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.95 kB
devtools/dist/devtools.mjs 272 B
dist/preact.mjs 4.88 kB
hooks/dist/hooks.mjs 1.56 kB
jsx-runtime/dist/jsxRuntime.mjs 856 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.606% (-0.004%) from 98.61% — agent/simplify-check-props-stack into main

@JoviDeCroock
JoviDeCroock merged commit 44b51b3 into main Aug 24, 2026
13 checks passed
@JoviDeCroock
JoviDeCroock deleted the agent/simplify-check-props-stack branch August 24, 2026 12:55
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants