fix(demo): declare the sass dependency vite's scss compilation needs - #5206
Merged
Conversation
demo/index.jsx imports style.scss, but sass was never declared in demo/package.json — only an orphaned node_modules/sass@1.53.0 entry in the lockfile kept it working: npm ci installs the lockfile verbatim (orphans included), while a fresh npm install prunes the unreachable entry and rewrites the lockfile, after which vite fails with 'Preprocessor dependency "sass-embedded" not found'. Declare sass@^1.53.0 (matching the existing lockfile entry) so both install paths produce a working demo.
JoviDeCroock
approved these changes
Aug 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demo/index.jsximportsstyle.scss, butsasswas never declared indemo/package.json— only an orphanednode_modules/sass@1.53.0entry indemo/package-lock.jsonkept it working:npm ciinstalls the lockfile verbatim (orphaned entries included), so the demo happens to run;npm installprunes the unreachable entry and rewrites the lockfile, after whichnpm run devfails with:This reproduces on current
mainas well as the 10.x line (the orphaned entry dates back to the vite migration of the demo).The fix declares
sass@^1.53.0— matching the version already present in the lockfile — so the lockfile change is a single line turning the orphaned entry into a reachable one. Verified that bothnpm ciand a freshnpm installnow produce a demo where vite compilesstyle.scsssuccessfully.