Skip to content

Remove redundant portal children guard - #5179

Merged
JoviDeCroock merged 2 commits into
mainfrom
refactor/remove-portal-children-guard
Jul 29, 2026
Merged

Remove redundant portal children guard#5179
JoviDeCroock merged 2 commits into
mainfrom
refactor/remove-portal-children-guard

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

Portal vnodes always have a _children array after diffing or error recovery, so this removes the redundant guard before remounting children into a new container.

Co-authored with GPT-5.6-sol.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

⏳ Benchmarks are currently running. Results below are out of date.

duration

  • create10k: unsure 🔍 -0% - +1% (-3.00ms - +5.25ms)
    preact-local vs preact-main
  • filter-list: slower ❌ 0% - 1% (0.01ms - 0.25ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.35ms - +0.65ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.04ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +3% (-0.49ms - +1.76ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +5% (-0.04ms - +0.12ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.19ms - +0.28ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -2% - +4% (-0.73ms - +1.22ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +4% (-0.07ms - +0.21ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +1% (-0.04ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

⏳ Benchmarks are currently running. Results below are out of date.
create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local823.24ms - 828.72ms-unsure 🔍
-0% - +1%
-3.00ms - +5.25ms
preact-main821.77ms - 827.94msunsure 🔍
-1% - +0%
-5.25ms - +3.00ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.23ms - 19.26ms-unsure 🔍
-0% - +0%
-0.03ms - +0.01ms
preact-main19.25ms - 19.27msunsure 🔍
-0% - +0%
-0.01ms - +0.03ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.81ms-slower ❌
0% - 1%
0.01ms - 0.25ms
preact-main16.54ms - 16.59msfaster ✔
0% - 1%
0.01ms - 0.25ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.57ms - 1.57ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.57ms - 1.57msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local54.32ms - 55.05ms-unsure 🔍
-1% - +1%
-0.35ms - +0.65ms
preact-main54.19ms - 54.88msunsure 🔍
-1% - +1%
-0.65ms - +0.35ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.00ms - 5.25ms-unsure 🔍
-1% - +4%
-0.07ms - +0.21ms
preact-main4.98ms - 5.12msunsure 🔍
-4% - +1%
-0.21ms - +0.07ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.58ms-unsure 🔍
-0% - +0%
-0.02ms - +0.04ms
preact-main16.52ms - 16.57msunsure 🔍
-0% - +0%
-0.04ms - +0.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.75ms - 3.76msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5717
  • Commit: d610cf6

duration

VersionAvg timevs preact-localvs preact-main
preact-local55.11ms - 56.64ms-unsure 🔍
-1% - +3%
-0.49ms - +1.76ms
preact-main54.41ms - 56.07msunsure 🔍
-3% - +1%
-1.76ms - +0.49ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.02ms - 3.03ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.02ms - 3.03msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.86ms - 28.52ms-unsure 🔍
-2% - +2%
-0.42ms - +0.56ms
preact-main27.75ms - 28.49msunsure 🔍
-2% - +1%
-0.56ms - +0.42ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.48ms - 33.53ms-unsure 🔍
-4% - +2%
-1.19ms - +0.60ms
preact-main32.57ms - 34.03msunsure 🔍
-2% - +4%
-0.60ms - +1.19ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.45ms - 29.43ms-faster ✔
0% - 5%
0.02ms - 1.51ms
preact-main29.15ms - 30.27msslower ❌
0% - 5%
0.02ms - 1.51ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.27ms - 25.51ms-unsure 🔍
-1% - +0%
-0.20ms - +0.13ms
preact-main25.32ms - 25.53msunsure 🔍
-0% - +1%
-0.13ms - +0.20ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.59ms - 24.89ms-unsure 🔍
-3% - +5%
-0.66ms - +1.30ms
preact-main23.18ms - 24.66msunsure 🔍
-5% - +3%
-1.30ms - +0.66ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.32ms - 20.77ms-unsure 🔍
-1% - +2%
-0.31ms - +0.44ms
preact-main20.18ms - 20.77msunsure 🔍
-2% - +1%
-0.44ms - +0.31ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #5717
  • Commit: d610cf6

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.12ms - 2.24ms-unsure 🔍
-2% - +5%
-0.04ms - +0.12ms
preact-main2.09ms - 2.20msunsure 🔍
-5% - +2%
-0.12ms - +0.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.02ms - 1.06ms-unsure 🔍
-4% - +1%
-0.04ms - +0.01ms
preact-main1.04ms - 1.07msunsure 🔍
-1% - +4%
-0.01ms - +0.04ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.90ms - 30.24ms-unsure 🔍
-1% - +1%
-0.19ms - +0.28ms
preact-main29.86ms - 30.19msunsure 🔍
-1% - +1%
-0.28ms - +0.19ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.28ms - 1.28ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.28ms - 1.28msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.39ms - 32.76ms-unsure 🔍
-2% - +4%
-0.73ms - +1.22ms
preact-main31.13ms - 32.52msunsure 🔍
-4% - +2%
-1.22ms - +0.73ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.99ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.98ms - 2.99msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown

Size Change: -4 B (-0.03%)

Total Size: 15.8 kB

📦 View Changed
Filename Size Change
dist/preact.mjs 5 kB -4 B (-0.08%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.mjs 3.71 kB
debug/dist/debug.mjs 3.89 kB
devtools/dist/devtools.mjs 274 B
hooks/dist/hooks.mjs 1.55 kB
jsx-runtime/dist/jsxRuntime.mjs 861 B
test-utils/dist/testUtils.mjs 473 B

compressed-size-action

@coveralls

coveralls commented Jul 28, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 98.534%. remained the same — refactor/remove-portal-children-guard into main

@JoviDeCroock
JoviDeCroock merged commit 247470e into main Jul 29, 2026
4 checks passed
@JoviDeCroock
JoviDeCroock deleted the refactor/remove-portal-children-guard branch July 29, 2026 11:04
@JoviDeCroock JoviDeCroock mentioned this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants