Fix compat Suspense hydration children recovery - #5146
Merged
Conversation
Assisted-By: devx/e4332ca9-5b89-489a-90de-4e51c2b124d8
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
Merged
|
Size Change: +6 B (+0.01%) Total Size: 48 kB 📦 View Changed
ℹ️ View Unchanged
|
|
coverage: 98.528%. remained the same — JoviDeCroock/cherry-pick-pr-5145 into main |
andrewiggins
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-ports the compat Suspense hydration children recovery fix from
v10.x(#5144, released in 10.29.5 / #5145) tomain.Hydrated Suspense can recover a VNode with no DOM and no initialized children, then compat's Suspense catch path can copy
oldVNode._childrenback tonull. A later bailout expects_childrento be iterable and crashes.This normalizes recovered compat Suspense children to an empty array and adds a regression for the no-DOM hydrated suspension bailout path.
🤖 Generated with Claude Code and reviewed by me