Fix hydration-susepsnse crashing due to sCU bail - #5134
Merged
Conversation
JoviDeCroock
force-pushed
the
patch-crashing-at-suspense-bail
branch
from
July 3, 2026 07:25
1fb6634 to
d781aa5
Compare
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: -20 B (-0.03%) Total Size: 79.6 kB 📦 View Changed
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Jul 3, 2026
JoviDeCroock
force-pushed
the
patch-crashing-at-suspense-bail
branch
4 times, most recently
from
July 3, 2026 08:53
5c0daec to
f98dbbc
Compare
Assisted-By: devx/f79ddc2d-9f3b-44d1-85dc-4cb2c75c5ad5
JoviDeCroock
force-pushed
the
patch-crashing-at-suspense-bail
branch
from
July 3, 2026 09:02
f98dbbc to
c3b4f0f
Compare
Merged
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but oldVNode._children is null, so it crashes.
7. The fix makes the recovery path establish the invariant that recovered vnodes always have iterable _children: partial children if already produced, old children if available, otherwise [].