Skip to content

Fix Suspense undefined prop revalidation - #5133

Merged
JoviDeCroock merged 1 commit into
mainfrom
fix/suspense-undefined-prop-revalidation
Jul 1, 2026
Merged

Fix Suspense undefined prop revalidation#5133
JoviDeCroock merged 1 commit into
mainfrom
fix/suspense-undefined-prop-revalidation

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-3.89ms - +4.78ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.16ms - +0.07ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +3% (-1.52ms - +1.67ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +1% (-0.73ms - +0.19ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.05ms - +0.48ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.09ms - +0.08ms)
    preact-local vs preact-main
  • todo: slower ❌ 0% - 2% (0.07ms - 0.78ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +2% (-1.52ms - +0.75ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -4% - +2% (-0.20ms - +0.13ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +4% (-0.03ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local824.09ms - 830.51ms-unsure 🔍
-0% - +1%
-3.89ms - +4.78ms
preact-main823.95ms - 829.76msunsure 🔍
-1% - +0%
-4.78ms - +3.89ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.07ms - 19.08ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.07ms - 19.07msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.52ms - 16.65ms-unsure 🔍
-1% - +0%
-0.16ms - +0.07ms
preact-main16.54ms - 16.72msunsure 🔍
-0% - +1%
-0.07ms - +0.16ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.55ms - 1.55ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main1.55ms - 1.55msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local58.46ms - 60.74ms-unsure 🔍
-3% - +3%
-1.52ms - +1.67ms
preact-main58.41ms - 60.64msunsure 🔍
-3% - +3%
-1.67ms - +1.52ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.05ms - 5.25ms-unsure 🔍
-4% - +2%
-0.20ms - +0.13ms
preact-main5.06ms - 5.31msunsure 🔍
-2% - +4%
-0.13ms - +0.20ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.46ms - 16.57ms-unsure 🔍
-4% - +1%
-0.73ms - +0.19ms
preact-main16.32ms - 17.24msunsure 🔍
-1% - +4%
-0.19ms - +0.73ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.74ms - 3.74ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.74ms - 3.74msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5608
  • Commit: 0cb3512

duration

VersionAvg timevs preact-localvs preact-main
preact-local54.45ms - 55.46ms-unsure 🔍
-2% - +1%
-1.05ms - +0.48ms
preact-main54.66ms - 55.82msunsure 🔍
-1% - +2%
-0.48ms - +1.05ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.01ms - 3.02ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main3.01ms - 3.01msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local27.22ms - 28.01ms-unsure 🔍
-2% - +2%
-0.59ms - +0.53ms
preact-main27.24ms - 28.04msunsure 🔍
-2% - +2%
-0.53ms - +0.59ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.28ms - 32.53ms-unsure 🔍
-4% - +2%
-1.20ms - +0.58ms
preact-main31.58ms - 32.85msunsure 🔍
-2% - +4%
-0.58ms - +1.20ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local29.46ms - 30.56ms-unsure 🔍
-1% - +4%
-0.37ms - +1.30ms
preact-main28.91ms - 30.18msunsure 🔍
-4% - +1%
-1.30ms - +0.37ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.00ms - 25.24ms-unsure 🔍
-0% - +1%
-0.11ms - +0.26ms
preact-main24.90ms - 25.18msunsure 🔍
-1% - +0%
-0.26ms - +0.11ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local22.57ms - 24.06ms-unsure 🔍
-6% - +4%
-1.30ms - +0.88ms
preact-main22.74ms - 24.32msunsure 🔍
-4% - +6%
-0.88ms - +1.30ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.42ms - 20.80ms-unsure 🔍
-2% - +1%
-0.33ms - +0.29ms
preact-main20.39ms - 20.88msunsure 🔍
-1% - +2%
-0.29ms - +0.33ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 200
  • Built by: CI #5608
  • Commit: 0cb3512

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.97ms - 2.11ms-unsure 🔍
-5% - +4%
-0.09ms - +0.08ms
preact-main1.99ms - 2.10msunsure 🔍
-4% - +5%
-0.08ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.03ms - 1.08ms-unsure 🔍
-3% - +4%
-0.03ms - +0.05ms
preact-main1.02ms - 1.08msunsure 🔍
-4% - +3%
-0.05ms - +0.03ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.78ms - 32.42ms-slower ❌
0% - 2%
0.07ms - 0.78ms
preact-main31.52ms - 31.84msfaster ✔
0% - 2%
0.07ms - 0.78ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.26ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.26ms - 1.26msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.77ms - 33.36ms-unsure 🔍
-5% - +2%
-1.52ms - +0.75ms
preact-main32.14ms - 33.76msunsure 🔍
-2% - +5%
-0.75ms - +1.52ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.97ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.96ms - 2.98msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Size Change: +10 B (+0.02%)

Total Size: 48.2 kB

📦 View Changed
Filename Size Change
dist/preact.js 4.87 kB +4 B (+0.08%)
dist/preact.mjs 4.89 kB +3 B (+0.06%)
dist/preact.umd.js 4.93 kB +3 B (+0.06%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.97 kB
compat/dist/compat.mjs 3.91 kB
compat/dist/compat.umd.js 4.04 kB
debug/dist/debug.js 3.91 kB
debug/dist/debug.mjs 3.91 kB
debug/dist/debug.umd.js 3.99 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.mjs 1.55 kB
hooks/dist/hooks.umd.js 1.59 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 98.491%. remained the same — fix/suspense-undefined-prop-revalidation into main

@JoviDeCroock
JoviDeCroock merged commit 627da90 into main Jul 1, 2026
13 checks passed
@JoviDeCroock
JoviDeCroock deleted the fix/suspense-undefined-prop-revalidation branch July 1, 2026 10:08
@JoviDeCroock JoviDeCroock mentioned this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants