perf(core): create hot path for unmounting a tree of context - #4396
Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10k
duration
usedJSHeapSize
filter-list
duration
usedJSHeapSize
hydrate1k
duration
usedJSHeapSize
many-updates
duration
usedJSHeapSize
replace1k
duration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-update
duration
usedJSHeapSize
todo
duration
usedJSHeapSize
update10th1k
duration
usedJSHeapSize
|
|
Size Change: +61 B (+0.1%) Total Size: 61.6 kB
ℹ️ View Unchanged
|
rschristian
approved these changes
May 22, 2024
Merged
This was referenced Aug 14, 2024
This was referenced Sep 3, 2024
JoviDeCroock
added a commit
that referenced
this pull request
Aug 6, 2026
`subs = null` on the Provider's componentWillUnmount was added in #4396 as a hot path: back then `subs` was an array and each unmounting consumer paid an O(n) `splice(indexOf(c), 1)`, so nulling the list short-circuited an O(n^2) teardown. `subs` is a Set now and `delete` is O(1), so the short-circuit no longer buys anything and the null guard in the consumer wrapper can go too. The Set is still released with the Provider instance: every subscriber is a descendant, so they all unmount and remove themselves first. preact 4491 -> 4483 B br Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently when we unmount an entire tree we have to look at the subscribers of the Provider even though this is unmounted. This can also avoid a memory leak by freeing all subs automatically even though components could refer to them, all though this is very much an edge case.
Resolves #4347