SongSelectV2: Scroll to selection instantly after a filter #35431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#33379. Pretty sure this matches song select V1. The two call sites where the old one does instant scrolls are: https://github.com/ppy/osu/blob/30412ba3f2c5b6debb9a0e3b930da6cc156852db/osu.Game/Screens/Select/BeatmapCarousel.cs#L672 which happens just after a filter, and https://github.com/ppy/osu/blob/30412ba3f2c5b6debb9a0e3b930da6cc156852db/osu.Game/Screens/Select/BeatmapCarousel.cs#L683 which is a bit more difficult to pin down, but generally appears to happen on changes to the visible items, which on `SongSelectV2` triggers a re-filter anyway.
bdach
added
the
type/behavioural
peppy
approved these changes
Oct 24, 2025
github-project-automation
bot
moved this from Pending Review
to Done
in osu! untitled project
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Screen.Recording.2025-10-24.at.13.33.10-1.mov
After:
Screen.Recording.2025-10-24.at.13.33.58-1.mov
Closes #33379.
Pretty sure this matches song select V1. The two call sites where the old one does instant scrolls are:
osu/osu.Game/Screens/Select/BeatmapCarousel.cs
Line 672 in 30412ba
which happens just after a filter, and
osu/osu.Game/Screens/Select/BeatmapCarousel.cs
Line 683 in 30412ba
which is a bit more difficult to pin down, but generally appears to happen on changes to the visible items, which on
SongSelectV2triggers a re-filter anyway.