Skip to content

Conversation

@bdach
Copy link
Collaborator

@bdach bdach commented Oct 24, 2025

Instead of truncating.

Screen.Recording.2025-10-24.at.11.11.19.mov

RFC. Addresses #35404.

The one "tiny" problem is that the "click to search" functionality of these texts is maybe a bit worse now, because the clickable target is now the full width of the wedge rather than autosized to the text. Salvaging this is maybe possible, but definitely annoying, so I'd rather not frontload it.

bdach added 2 commits October 24, 2025 11:07
Instead of truncating.

Addresses ppy#35404.

The one "tiny" problem is that the "click to search" functionality of
these texts is maybe a bit worse now, because the clickable target is
now the full width of the wedge rather than autosized to the text.
Salvaging this is *maybe* possible, but *definitely* annoying, so I'd
rather not frontload it.
…nges size

This is actually possible in current usages if you e.g. toggle "use
original metadata" on/off which will change the width of the underlying
sprite texts. Or by setting window size. Pick your poison.
@bdach bdach requested a review from peppy October 24, 2025 09:18
@bdach bdach self-assigned this Oct 24, 2025
@bdach bdach added area:song-select type/cosmetic Only affects the game visually. Doesn't affect things working or not working. quick fix Tasks which were taken on because they take no time to fix labels Oct 24, 2025
@bdach bdach moved this from Next up to Pending Review in osu! untitled project Oct 24, 2025
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:song-select quick fix Tasks which were taken on because they take no time to fix size/L type/cosmetic Only affects the game visually. Doesn't affect things working or not working.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants