Disable presenting beatmaps during quick play #35420
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35353
Fixes #35328
This is a bit of a workaround. It touches on two issues:
PerformFromMenuRunnerwill continuously try to exit the current screen. If the "are you sure you want to exit multiplayer" dialog remains open until the player loader, it will exit the player loader screen. This can be simulated with this patch: https://gist.github.com/smoogipoo/b4ed97ce99e350ed16b6ed036b299b11 (press the spectate button on an autostart room and wait until player loader before pressing cancel).I'm not sure how to fix this yet.
The second issue is that any sort of import notification will give you a "X has been imported, click to view" button, which really shouldn't exist in quick play. This one goes deep and I'm not sure how to resolve it from every possible case of import (e.g. dragging files into the game).
By disabling beatmap presents, we effectively make both of the above operations into no-ops.