Disallow zero-length sliders from specifying a non-zero number of repeats

[bdach]

• Pending diffcalc runs in order to estimate possible impact of this change on all ranked beatmaps

[bdach]

!diffcalc
RULESET=osu
NO_ASPIRE=0
GENERATORS=sr

[bdach]

!diffcalc
RULESET=catch
NO_ASPIRE=0
GENERATORS=sr

[github-actions]

Target: #35220
Spreadsheet: https://docs.google.com/spreadsheets/d/16c1VH5xm4TLqjcynS-Lf3iqKEFmEWySE67-PUmgVSbU/edit

[github-actions]

Target: #35220
Spreadsheet: https://docs.google.com/spreadsheets/d/1r9cHPo3o1WA-fEcn0f0iYxRJkHertIuVKjjjLTURwdA/edit

[peppy]

Spreadsheet looks clean.

[bdach]

It does, which makes me a little suspicious given that I'd expect to see at least the loved beatmap that sparked this in there.

I'll run one more and see if anything changes:

!diffcalc
RULESET=osu
NO_ASPIRE=0
GENERATORS=score

[github-actions]

Target: #35220
Spreadsheet: https://docs.google.com/spreadsheets/d/1kwD6j456NyVvOVntm-KjfirbXAgPRfzMhk9fRE7M1GE/edit

[bdach]

Yeah okay. I'm much happier with that last sheet. Other than the beatmap that this is targeting it also shows this beatmap as affected and, let's just say, I have run into this mapper before, and they're definitely... uhhhhhh... a fan of testing the game limits and taking creative liberties with those? is the polite way to put it? And that map does feature several zero-length sliders with non-zero repeat counts.

No idea why the "score losses" tab is showing a bunch of rows with score losses of zero, but I also don't think I am going to worry about that too much. Undrafting.