Skip to content

Conversation

@bdach
Copy link
Collaborator

@bdach bdach commented Sep 4, 2025

Reported internally.

Review with whitespace off strongly recommended.

For context as to why this diff and why didn't it crash, see

items.Add(new OsuMenuItem(UsersStrings.ReportButtonText, MenuItemType.Destructive, ReportRequested));

if (this.FindClosestParent<PopoverContainer>() != null)
{
// This guards against cases like in-game chat where there's no available popover container.
// There may be a future where a global one becomes available, at which point this code may be unnecessary.
//
// See:
// https://github.com/ppy/osu/pull/23698
// https://github.com/ppy/osu/pull/14554
drawableUsername.ReportRequested = this.ShowPopover;
}

@bdach bdach self-assigned this Sep 4, 2025
@bdach bdach added the quick fix Tasks which were taken on because they take no time to fix label Sep 4, 2025
@bdach bdach moved this to Pending Review in osu! untitled project Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:playlists quick fix Tasks which were taken on because they take no time to fix size/L

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants