Fix crash when trying to test map in the editor

[minetoblend]

Closes #34846

Turns out the editor player was relying on the 1-frame delay before hitobject drawables would become alive prior to #34830.
Issue here was that with hitobjects becoming alive immediately, they already had a chance to update their state to "miss" before the player can manually set their result now.
This lead to a null pointer exception in the playfield's update look due to JudgementResult.RawTime being null.

Assigning a time to the result did fix the crash but the logic of marking the objectse was still broken, so tried to hook things up to update before the hitobject has a chance to update it's own state. Not 100% confident in this fix quality wise though so maybe reverting #34830 is a better option.

[bdach]

very curious to hear why this is being pr'd 30 minutes after i self assigned the issue for investigation

they already had a chance to update their state to "miss" before the player can manually set their result now

please point out the exact mechanism of this failure, this text description is insufficient for my understanding of the issue

[minetoblend]

very curious to hear why this is being pr'd 30 minutes after i self assigned the issue for investigation

Already answered on discord gonna skip over over that

please point out the exact mechanism of this failure, this text description is insufficient for my understanding of the issue

there's 2 failure mechanisms here

• due to the hitobjects having undergone an update-loop already, if they update their result on the first update loop their entry lands in Playfield.judgedEntries. The editor player would then replace the entry's result with a new one, which was missing a value for Result.RawTime, leading to an assertion error (or null pointer exception in production) in

  osu/osu.Game/Rulesets/UI/Playfield.cs

  Lines 280 to 282 in 5de7cc3

  	Debug.Assert(result?.RawTime != null);
  	if (Time.Current >= result.RawTime.Value)

• assigning a value to it does prevent the crash, but since the object got into miss state through the default flow it will already have notified all sorts of other playfield components, leading to the miss sound being played and the judgment drawables being shown on the playfield.

[minetoblend]

I'm very puzzled by the test failure here. I looked at it with a debugger and it looks like Player.load() is never being called, leading to DrawableRuleset never being set? I double checked the order in which things are supposed in osu-framework and this should definitely have run before LoadAsyncComplete.
nvm just saw that it won't initialize when playableBeatmap is null

[minetoblend]

There was one more test failure due to a mismatch in which objects had a result applied and which ones were received by the score processor, which could lead to the score processor never receiving the results for some hitobjects and it's HasCompleted value never becoming true.
It does pass now but I'm not 100% confident that there's no way this can't still somehow fail now.

[bdach]

horrible hack but the previous code was already a hack so I'm not going to split hairs

[peppy]

Just a minor one.