Add secondary keys for osu!mania #34867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Potentially useful for special style support, but not sure if we want secondary binds for normal keys |
Contributor
|
This looks fine to me. Actually, I find it strange that osu! doesn't support additional key bindings when other games like lr2 and beatoraja do. |
bdach
reviewed
Sep 2, 2025
Comment on lines
26
to
27
| secondaryLeftKeys = new[] { InputKey.Q, InputKey.W, InputKey.E, InputKey.R, InputKey.B }; | ||
| secondaryRightKeys = new[] { InputKey.M, InputKey.I, InputKey.O, InputKey.P, InputKey.BracketLeft }; |
Collaborator
There was a problem hiding this comment.
Is there any reason for why these are (a) bound to keys already rather than to InputKey.None like in the dual stage generator, (b) bound to these keys in particular? Binding both ASDFV and QWERB on the left side for instance seems like not the best idea because users could feasibly mis-press a button because the alternate bindings are so close to each other in proximity.
Contributor
Author
There was a problem hiding this comment.
alright I'll change this to none
bdach
approved these changes
Sep 3, 2025
github-project-automation
bot
moved this from Pending Review
to Done
in osu! untitled project
This was referenced Sep 5, 2025
This was referenced Sep 8, 2025
This was referenced Oct 2, 2025
This was referenced Oct 7, 2025
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds secondary keys for osu!mania to match other rulesets. It's possible to add secondary keys in other rhythm games like etterna or fnf. also this will be especially useful for people who want to play mania with controller or special play styles.