Skip to content

Conversation

@peppy
Copy link
Member

@peppy peppy commented Aug 27, 2025

The BeatmapDifficultyCache handles mod changes, so handling locally is unnecessary. By handling locally, it creates a visual issue when adjusting mods often. Test using Ctrl +/- at song select and observing that without this change, the star rating will flicker back to the default due to the local re-fetch.

Before:

osu.2025-08-27.at.09.33.29.mp4

After:

osu.2025-08-27.at.09.32.37.mp4

The `BeatmapDifficultyCache` handles mod changes, so handling locally is
unnecessary. By handling locally, it creates a visual issue when
adjusting mods often. Test using Ctrl +/- at song select and observing
that without this change, the star rating will flicker back to the
default due to the local re-fetch.
@peppy peppy requested a review from a team August 27, 2025 09:32
@peppy peppy force-pushed the fix-star-rating-weird-mod-double-handling branch from 3cca926 to fda40d7 Compare August 27, 2025 09:33
@bdach bdach self-requested a review August 27, 2025 10:44
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also be applied to

ruleset.BindValueChanged(_ =>
{
computeStarRating();
updateKeyCount();
});

ruleset.BindValueChanged(_ =>
{
computeStarRating();
updateKeyCount();
});
mods.BindValueChanged(_ =>
{
computeStarRating();
updateKeyCount();
}, true);

@bdach bdach changed the title Fix beatmap panels locally handling mod changes unnecessarily Fix beatmap panels locally handling mod and ruleset changes unnecessarily Aug 27, 2025
@peppy peppy merged commit 5abd93e into ppy:master Aug 27, 2025
5 of 9 checks passed
@peppy peppy deleted the fix-star-rating-weird-mod-double-handling branch August 27, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants