Show indicator in replay player once replay fails #34628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, there was `AllowFailAnimation` (used by multiplayer) and `OnFail()` (used by score submitting implementations of player to ensure a failed play submits). The former is replaced by `PerformFail()` which allows for arbitrary operations on failure, which replay player shall leverage in subsequent commits. The latter would ideally be replaced by nothing, but it's placed in a very awkward place behind a schedule, so by force of necessity to avoid code duplication it's replaced by `ConcludeFailedScore()` which is overridden to submit the score in all submitting players --- except for multiplayer, which is never supposed to be calling it, so in that case it just throws an exception.
This indicator allows the player to either rewind to an earlier part of the replay, or to proceed to results. It also plays a shortened variant of the failure animation SFX.
As indicated in the inline comment this is very best effort, just to make the HP bar not very obviously stuck in a very obviously incorrect state after the replay is rewound from a failure. There's likely to be a bunch of replay accuracy issues related to this, but I'm just making the minimum effort to get this to work semi-acceptably for now.
peppy
reviewed
Aug 15, 2025
| /// <summary> | ||
| /// "Go to results" | ||
| /// </summary> | ||
| public static LocalisableString GoToResults => new TranslatableString(getKey(@"go_to_results"), @"Go to results"); |
Member
There was a problem hiding this comment.
Was thinking "Show results" might fit better but given it's shifting between game screens I think this is probably best left as-is.
peppy
approved these changes
Aug 15, 2025
Member
peppy
left a comment
peppy
left a comment
There was a problem hiding this comment.
Seems to work pretty well. Feels more than good enough for a first iteration.
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indicator allows the player to either rewind to an earlier part of the replay, or to proceed to results. It also plays a shortened variant of the failure animation SFX.
2025-08-12.14-35-51.mov
In addition to the main piece, this goes on a few side missions as well:
Refactor fail management to be more centralised
Before this commit, there was
AllowFailAnimation(used by multiplayer) andOnFail()(used by score submitting implementations of player to ensure a failed play submits).The former is replaced by
PerformFail()which allows for arbitrary operations on failure, which replay player leverages here for the main piece to work. The latter would ideally be replaced by nothing, but it's placed in a very awkward place behind a schedule, so by force of necessity to avoid code duplication it's replaced byConcludeFailedScore()which is overridden to submit the score in all submitting players --- except for multiplayer, which is never supposed to be calling it, so in that case it just throws an exception.The reason I did this is not to be a hypocrite after I complained about the fail flows last time.
Add rudimentary support of rewinding failed state to health processor
As indicated in the inline comment this is very best effort, just to make the HP bar not very obviously stuck in a very obviously incorrect state after the replay is rewound from a failure. There's likely to be a bunch of replay accuracy issues related to this, but I'm just making the minimum effort to get this to work semi-acceptably for now.
If this is too much then I'll drop this change with no contest.