Add "Argon" unstable rate counter #34592
Merged
+185
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiviexd
changed the title
bdach
requested changes
Aug 11, 2025
Also fixes value change callbacks in BDL (very bad) and potential lingering initial transforms.
bdach
approved these changes
Aug 12, 2025
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
@Hiviexd please check my commits at the end here for future reference:
BindValueChanged()callbacks should never be registered in BDL due to threading concerns- tests should never need to arbitrarily call
base.SetUpSteps()in the middle of the test (and to my eye, they never did actually need to do that)
Member
Author
|
Good to know for future reference, thanks. |
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVIDIA_Overlay_N58L4hF8aI.mp4
Resolves #34591
Tried following the structure of the pp counter for this since they're on similar circumstances.