Skip to content

Conversation

@peppy
Copy link
Member

@peppy peppy commented Aug 4, 2025

Avoids UI components shifting around, breaking muscle memory.

Avoids UI components shifting around, breaking muscle memory.

- Addresses ppy#34443.
- Closes ppy#34415.
- Supersedes and closes ppy#34446.
@peppy peppy added area:song-select type/cosmetic Only affects the game visually. Doesn't affect things working or not working. labels Aug 4, 2025
@peppy peppy added quick fix Tasks which were taken on because they take no time to fix and removed size/S labels Aug 4, 2025
@bdach bdach self-requested a review August 4, 2025 07:52
@bdach
Copy link
Collaborator

bdach commented Aug 4, 2025

unsure how to feel about the sort mode dropdown remaining at the last value chosen before it was disabled when switching to a leaderboard scope that does not support sorting

Screenshot 2025-08-04 at 09 57 22

is kind of ambiguous as to whether the resulting scores should be sorted by date or not

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the above fine I guess

@peppy
Copy link
Member Author

peppy commented Aug 4, 2025

Good observation. I've fixed this, and also made sure we're properly binding to the configuration value, in case it's altered elsewhere in the game at a later point.

bdach
bdach approved these changes Aug 4, 2025
@bdach bdach merged commit d72cb6e into ppy:master Aug 4, 2025
6 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Next up to Done in osu! untitled project Aug 4, 2025
@peppy peppy deleted the sort-mode-dropdown-always-show branch August 4, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:song-select quick fix Tasks which were taken on because they take no time to fix size/S type/cosmetic Only affects the game visually. Doesn't affect things working or not working.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

"step" when hiding Sort dropdown on SSV2

2 participants